Attempt to fix ash tests on Chrome OS valgrind

Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG=602487
Committed: https://crrev.com/f2b280f227d364e58576c282958837289aa87b52
Cr-Commit-Position: refs/heads/master@{#387108}

[ananta, 2016-04-13 01:22:55]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2016-04-13 01:23:23]

Description was changed from

==========
Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

BUG=602487
==========

to

==========
Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG=602487
==========

[sky, 2016-04-13 16:32:10]

LGTM

https://codereview.chromium.org/1885653003/diff/60001/ui/wm/core/cursor_manag...
File ui/wm/core/cursor_manager.h (right):

https://codereview.chromium.org/1885653003/diff/60001/ui/wm/core/cursor_manag...
ui/wm/core/cursor_manager.h:46: static void ResetState();
ResetCursorVisibilityStateForTest.

[ananta, 2016-04-13 19:41:14]

https://codereview.chromium.org/1885653003/diff/60001/ui/wm/core/cursor_manag...
File ui/wm/core/cursor_manager.h (right):

https://codereview.chromium.org/1885653003/diff/60001/ui/wm/core/cursor_manag...
ui/wm/core/cursor_manager.h:46: static void ResetState();
On 2016/04/13 16:32:10, sky wrote:
> ResetCursorVisibilityStateForTest.

Done.

[ananta, 2016-04-13 19:42:02]

ananta@chromium.org changed reviewers:
+ thestig@chromium.org

[ananta, 2016-04-13 19:42:03]

+thestig for tools\valgrind owners

[Lei Zhang, 2016-04-13 20:18:50]

On 2016/04/13 19:42:03, ananta wrote:
> +thestig for tools\valgrind owners

You don't want to revert all of commit abc44825. It suppressed multiple bugs.

[ananta, 2016-04-13 20:46:24]

On 2016/04/13 20:18:50, Lei Zhang wrote:
> On 2016/04/13 19:42:03, ananta wrote:
> > +thestig for tools\valgrind owners
> 
> You don't want to revert all of commit abc44825. It suppressed multiple bugs.

Done. PTAL

[Lei Zhang, 2016-04-13 20:49:28]

lgtm

[ananta, 2016-04-13 20:51:33]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-04-13 20:51:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1885653003/#ps100001
(title: "Don't revert all of commit abc44825")

[commit-bot: I haz the power, 2016-04-13 20:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885653003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885653003/100001

[commit-bot: I haz the power, 2016-04-13 21:49:47]

Description was changed from

==========
Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG=602487
==========

to

==========
Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG=602487
==========

[commit-bot: I haz the power, 2016-04-13 21:49:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-13 21:50:42]

Description was changed from

==========
Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG=602487
==========

to

==========
Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG=602487

Committed: https://crrev.com/f2b280f227d364e58576c282958837289aa87b52
Cr-Commit-Position: refs/heads/master@{#387108}
==========

[commit-bot: I haz the power, 2016-04-13 21:50:43]

Patchset 6 (id:??) landed as
https://crrev.com/f2b280f227d364e58576c282958837289aa87b52
Cr-Commit-Position: refs/heads/master@{#387108}

[mfomitchev, 2016-04-13 22:00:32]

Drive-by: 
What about tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt and
tools/valgrind/memcheck/suppressions.txt?

[Lei Zhang, 2016-04-13 22:15:31]

On 2016/04/13 22:00:32, mfomitchev wrote:
> Drive-by: 
> What about tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt and
> tools/valgrind/memcheck/suppressions.txt?

What about them?