Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1885633003: Revert AlphaThresholdFilter to its old behavior wrt premul (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert AlphaThresholdFilter to its old behavior wrt premul TBR=borenet@google.com This fixes the "serialize-8888 gm imagealphathreshold_surface" failure related to: https://codereview.chromium.org/1879643003/ (Switch AlphaThresholdFilter over to new onFilterImage interface) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1885633003 Committed: https://skia.googlesource.com/skia/+/247e5341a483053862213f1bdda4ce5c47544b8f

Patch Set 1 #

Patch Set 2 : Revert AlphaThresholdFilter to prior behavior wrt premul #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-12 19:24:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885633003/20001
4 years, 8 months ago (2016-04-12 19:24:24 UTC) #6
Stephen White
LGTM
4 years, 8 months ago (2016-04-12 19:25:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 19:34:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885633003/20001
4 years, 8 months ago (2016-04-12 19:38:26 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 19:39:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/247e5341a483053862213f1bdda4ce5c47544b8f

Powered by Google App Engine
This is Rietveld 408576698