Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chromeos/ime/input_methods.txt

Issue 18856014: We should switch the keyboard layout to the layout the user set according to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix clang build. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/input_methods.txt
diff --git a/chromeos/ime/input_methods.txt b/chromeos/ime/input_methods.txt
index 85ee9b93c409ae32c7b14002e8f36c0d2c2d61e7..5b3335e6782e11881b75afd5e3ea7d4c6e863339 100644
--- a/chromeos/ime/input_methods.txt
+++ b/chromeos/ime/input_methods.txt
@@ -56,6 +56,15 @@
# XKB layout), you should also update IsMod3UsedByCurrentInputMethod() method
# in chrome/browser/ui/ash/event_rewriter.cc. Otherwise, Mod3Mask might be
# removed unexpectedly by the rewriter.
+#
+# If you add a new language such that some of its layouts can be used at
+# signin screen (e.g. it is "Full Latin Keyboard Layout" therefore allowing
+# input of gmail password), you should also update
+# kHasLatinKeyboardLanguageList[] in
+# chrome/browser/chromeos/input_method/input_method_manager_impl_ll.cc
Seigo Nonaka 2013/07/22 13:17:34 No need to do now, but how about introducing new l
Seigo Nonaka 2013/07/22 14:14:40 Ugh, /low/column/s please...
Alexander Alekseev 2013/07/22 14:24:21 Probably, but do we have any plugin-based layouts
+#
+# If you add a new keyboard layout for existing language, please ensure
+# that information in kHasLatinKeyboardLanguageList[] is still correct.
# U.S. English
xkb:us::eng us en-US

Powered by Google App Engine
This is Rietveld 408576698