We should switch the keyboard layout to the layout the user set according to

chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
 
 #include "base/callback.h"
+#include "base/chromeos/chromeos_version.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
+#include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_process_platform_part_chromeos.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
+#include "chrome/browser/chromeos/input_method/input_method_util.h"
 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
 #include "chrome/browser/chromeos/login/hwid_checker.h"
 #include "chrome/browser/chromeos/login/login_display_host_impl.h"
 #include "chrome/browser/chromeos/login/screen_locker.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/webui_login_display.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chrome/browser/chromeos/net/network_portal_detector.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
@@ skipping 64 matching lines @@
 // The Task posted to PostTaskAndReply in StartClearingDnsCache on the IO
 // thread.
 void ClearDnsCache(IOThread* io_thread) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (browser_shutdown::IsTryingToQuit())
     return;
 
   io_thread->ClearHostCache();
 }
 
+static bool Contains(const std::vector<std::string>& container,
+                     const std::string& value) {
+  return std::find(container.begin(), container.end(), value) !=
+         container.end();
+}
+
 }  // namespace
 
 namespace chromeos {
 
 namespace {
 
 const char kNetworkStateOffline[] = "offline";
 const char kNetworkStateOnline[] = "online";
 const char kNetworkStateCaptivePortal[] = "behind captive portal";
 const char kNetworkStateConnecting[] = "connecting";
@@ skipping 689 matching lines @@
   AddCallback("unlockOnLoginSuccess",
               &SigninScreenHandler::HandleUnlockOnLoginSuccess);
   AddCallback("frameLoadingCompleted",
               &SigninScreenHandler::HandleFrameLoadingCompleted);
   AddCallback("showLoadingTimeoutError",
               &SigninScreenHandler::HandleShowLoadingTimeoutError);
   AddCallback("updateOfflineLogin",
               &SigninScreenHandler::HandleUpdateOfflineLogin);
 }
 
+void SigninScreenHandler::RegisterPrefs(PrefRegistrySimple* registry) {
+  registry->RegisterDictionaryPref(prefs::kUsersLRUInputMethod);
+}
+
 void SigninScreenHandler::HandleGetUsers() {
   SendUserList(false);
 }
 
 void SigninScreenHandler::ClearAndEnablePassword() {
   CallJS("cr.ui.Oobe.resetSigninUI", false);
 }
 
 void SigninScreenHandler::ClearUserPodPassword() {
   CallJS("cr.ui.Oobe.clearUserPodPassword");
@@ skipping 136 matching lines @@
   }
 }
 
 void SigninScreenHandler::OnDnsCleared() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   dns_clear_task_running_ = false;
   dns_cleared_ = true;
   ShowSigninScreenIfReady();
 }
 
+void SigninScreenHandler::SetUserInputMethodHWDefault() {
+#if defined(OS_CHROMEOS)

[Nikita (slow), 2013/07/11 09:13:54]

No need for OS_CHROMEOS here as this class is already located in chromeos
specific folder.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+  chromeos::input_method::InputMethodManager* manager =
+      chromeos::input_method::InputMethodManager::Get();
+  manager->ChangeInputMethod(
+      manager->GetInputMethodUtil()->GetHardwareInputMethodId());
+#endif
+}
+
+void SigninScreenHandler::SetUserInputMethod(const std::string& username) {
+#if defined(OS_CHROMEOS)

[Nikita (slow), 2013/07/11 09:13:54]

nit: same here.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+  // Update keyboard layout to least recently used by the user
+  if (g_browser_process == NULL)

[Nikita (slow), 2013/07/11 09:13:54]

nit: drop this check.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+    return;
+
+  if (!base::chromeos::IsRunningOnChromeOS())

[Nikita (slow), 2013/07/11 09:13:54]

What about relying on stubs instead when not running on a real Chrome OS VM
image/device?

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+    return;
+
+  PrefService* local_state = g_browser_process->local_state();
+  DCHECK(local_state);

[Nikita (slow), 2013/07/11 09:13:54]

nit: Drop this DCHECK.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+
+  if (local_state == NULL)

[Nikita (slow), 2013/07/11 09:13:54]

nit: Drop this.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+    return;
+
+  chromeos::input_method::InputMethodManager* manager =
+      chromeos::input_method::InputMethodManager::Get();
+  DCHECK(manager);

[Nikita (slow), 2013/07/11 09:13:54]

nit: Drop this DCHECK.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+
+  bool succeed = false;
+  do {

[Nikita (slow), 2013/07/11 09:13:54]

You should delete this loop it is not really needed.
My proposal:

Have a utility method that tries to switch to user specific input method and
returns bool. Code that calls it will switch to default if needed.

Introducing this method will also help split this method into smaller parts.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+    const base::DictionaryValue* users_lru_input_methods =
+        local_state->GetDictionary(prefs::kUsersLRUInputMethod);
+
+    if (users_lru_input_methods == NULL) {
+      DLOG(WARNING) << "SetUserInputMethod('" << username

[Nikita (slow), 2013/07/11 09:13:54]

nit: I guess it is perfectly normal situation till at least one user signs in
that has latin-based input_methods.

No need for DLOG(WARNING) here.

[Alexander Alekseev, 2013/07/12 20:10:49]

Do all our users always have some latin input method enabled ?
Probably HW-default is always enabled, I think.

+                    << "'): no kUsersLRUInputMethod";
+      break;
+    }
+
+    std::string input_method;
+
+    if (!users_lru_input_methods->GetStringWithoutPathExpansion(
+            username, &input_method)) {
+      DLOG(WARNING) << "SetUserInputMethod('" << username

[Nikita (slow), 2013/07/11 09:13:54]

nit: Same here. This looks like a perfectly normal (rare but normal) situation
so no need for DLOG(WARNING).

[Alexander Alekseev, 2013/07/12 20:10:49]

But it's debug log, isn't it? I think I'd better have a trace of rare events at
least in debug log.

+                    << "'): no input method for this user";
+      break;
+    }
+
+    if (manager == NULL)

[Nikita (slow), 2013/07/11 09:13:54]

You don't have to check for manager not being NULL. It is assumed it is always
not NULL when we are accessing it. You could check its lifetime if you want.

If this assumption is not true this code better crash and generate crash report
instead of doing nothing.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+      break;
+
+    const chromeos::input_method::InputMethodUtil* ime_util =
+        manager->GetInputMethodUtil();
+    DCHECK(ime_util);

[Nikita (slow), 2013/07/11 09:13:54]

nit: Drop DCHECK

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+
+    if (ime_util == NULL)

[Nikita (slow), 2013/07/11 09:13:54]

Same here.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+      return;
+
+    if (input_method.empty())
+      break;
+
+    if (!manager->IsLanguageFullLatinKeyboard(
+            ime_util->GetLanguageCodeFromInputMethodId(input_method))) {
+      LOG(WARNING) << "SetUserInputMethod('" << username

[Nikita (slow), 2013/07/11 09:13:54]

nit: I propose dropping log message as well and just doing pref cleanup instead.

[Alexander Alekseev, 2013/07/12 20:10:49]

It is probably dangerous to silently drop user preferences. I've added pref
cleanup, but left log message. Do you think it is OK now?

+                   << "'): stored user LRU input method '" << input_method
+                   << "' is no longer Full Latin Keyboard Language."
+                   << " Use hardware default instead.";
+
+      break;
+    }
+
+    if (!Contains(chromeos::input_method::InputMethodManager::Get()
+                      ->GetActiveInputMethodIds(),

[Nikita (slow), 2013/07/11 09:13:54]

nit: -> should be on the previous line

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+                  input_method)) {
+      if (!chromeos::input_method::InputMethodManager::Get()->EnableInputMethod(

[Nikita (slow), 2013/07/11 09:13:54]

nit:

if (!chromeos::input_method::InputMethodManager::Get()->
        EnableInputMethod(input_method)) {

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+              input_method)) {
+        DLOG(ERROR) << "SigninScreenHandler::SetUserInputMethod('" << username
+                    << "'): user input method '" << input_method
+                    << "' is not enabled and enabling failed (ignored!).";
+      }
+    }
+    chromeos::input_method::InputMethodManager::Get()->ChangeInputMethod(

[Nikita (slow), 2013/07/11 09:13:54]

nit: this looks more readable:

chromeos::input_method::InputMethodManager::Get()->
    ChangeInputMethod(input_method);

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+        input_method);
+
+    succeed = true;
+  } while (false);
+
+  // This is also a case when LRU layout is set only for a few local users,
+  // thus others need to be switched to default locale.
+  // Otherwise they will end up using another user's locale to log in.
+  if (!succeed) {
+    DLOG(WARNING)

[Nikita (slow), 2013/07/11 09:13:54]

nit: No need for DLOG(WARNING), perfectly normal situation.

[Alexander Alekseev, 2013/07/12 20:10:49]

But it's debug log. Let's leave traces of rare events at least in debug log.

+        << "SetUserInputMethod('" << username
+        << "'): failed to set user layout. Switching to default '"
+        << (manager != NULL
+                ? manager->GetInputMethodUtil()->GetHardwareInputMethodId()
+                : "NULL") << "'";
+
+    SetUserInputMethodHWDefault();
+  }
+#endif
+}
+
 void SigninScreenHandler::ShowSigninScreenIfReady() {
   if (!dns_cleared_ || !cookies_cleared_ || !delegate_)
     return;
 
   std::string active_network =
       network_state_informer_->active_network_service_path();
   if (gaia_silent_load_ &&
       (!network_state_informer_->is_online() ||
        gaia_silent_load_network_ != active_network)) {
     // Network has changed. Force Gaia reload.
     gaia_silent_load_ = false;
     // Gaia page will be realoded, so focus isn't stolen anymore.
     focus_stolen_ = false;
   }
 
   // Note that LoadAuthExtension clears |email_|.
   if (email_.empty())
     delegate_->LoadSigninWallpaper();
   else
     delegate_->LoadWallpaper(email_);
 
+  // Set Least Recently used input method for the user

[Mattias Nissler (ping if slow), 2013/07/11 10:05:49]

nit: missing period.

[Alexander Alekseev, 2013/07/12 20:10:49]

Done.

+  if (!email_.empty())
+    SetUserInputMethod(email_);
+
   LoadAuthExtension(!gaia_silent_load_, false, false);
   UpdateUIState(UI_STATE_GAIA_SIGNIN, NULL);
 
   if (gaia_silent_load_) {
     // The variable is assigned to false because silently loaded Gaia page was
     // used.
     gaia_silent_load_ = false;
     if (focus_stolen_)
       HandleLoginWebuiReady();
   }
@@ skipping 192 matching lines @@
   if (gaia_silent_load_ && email_.empty()) {
     dns_cleared_ = true;
     cookies_cleared_ = true;
     ShowSigninScreenIfReady();
   } else {
     StartClearingDnsCache();
     StartClearingCookies(base::Bind(
         &SigninScreenHandler::ShowSigninScreenIfReady,
         weak_factory_.GetWeakPtr()));
   }
+  SetUserInputMethodHWDefault();
 }
 
 void SigninScreenHandler::HandleToggleEnrollmentScreen() {
   if (delegate_)
     delegate_->ShowEnterpriseEnrollmentScreen();
 }
 
 void SigninScreenHandler::HandleToggleKioskEnableScreen() {
   if (delegate_ &&
       !g_browser_process->browser_policy_connector()->IsEnterpriseManaged()) {
@@ skipping 460 matching lines @@
   rvh->ExecuteJavascriptInWebFrame(
       ASCIIToUTF16("//iframe[@id='signin-frame']\n//iframe"),
       ASCIIToUTF16(code));
 
   // Test properties are cleared in HandleCompleteLogin because the form
   // submission might fail and login will not be attempted after reloading
   // if they are cleared here.
 }
 
 }  // namespace chromeos