Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: remoting/client/jni/audio_player_impl.h

Issue 18856012: Create new remoting_client_jni target (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/audio_player_impl.h
diff --git a/remoting/client/jni/audio_player_impl.h b/remoting/client/jni/audio_player_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..cee1a6f8082566413496c24dec53efbb68ca4009
--- /dev/null
+++ b/remoting/client/jni/audio_player_impl.h
@@ -0,0 +1,32 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_CLIENT_JNI_AUDIO_PLAYER_IMPL_H_
+#define REMOTING_CLIENT_JNI_AUDIO_PLAYER_IMPL_H_
+
+#include "remoting/client/audio_player.h"
+
+namespace remoting {
+
+// Basic AudioPlayer implementation for client implementations that use JNI.
Wez 2013/07/09 17:34:47 It's not a basic implementation, it's dummy implem
solb 2013/07/10 00:01:19 I got rid of this whole class, which compiles now
+class AudioPlayerImpl : public AudioPlayer {
+ public:
+ AudioPlayerImpl();
+
+ protected:
+ //
Wez 2013/07/09 17:34:47 nit: Get rid of the blank line comments.
+ // AudioPlayer implementation:
Wez 2013/07/09 17:34:47 nit: : -> .
+ //
+ virtual uint32 GetSamplesPerFrame() OVERRIDE;
+
Wez 2013/07/09 17:34:47 nit: No need for a blank line between the overridd
+ virtual bool ResetAudioPlayer(
+ AudioPacket::SamplingRate sampling_rate) OVERRIDE;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(AudioPlayerImpl);
+};
+
+} // namespace remoting
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698