remoting/client/jni/audio_player_impl.cc - Issue 18856012: Create new remoting_client_jni target

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/jni/audio_player_impl.cc

Issue 18856012: Create new remoting_client_jni target (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/client/jni/audio_player_impl.h"

	6

	7 #include "base/logging.h"

	8

	9 namespace remoting {

	10

	11 AudioPlayerImpl::AudioPlayerImpl() {}

	12

	13 uint32 AudioPlayerImpl::GetSamplesPerFrame() {

	14 LOG(WARNING) << "AudioPlayerImpl::GetSamplesPerFrame() [unimplemented]";
	Wez 2013/07/09 17:34:47 nit: NOTIMPLEMENTED() nit: NOTIMPLEMENTED()
	15 return 0; // TODO(solb) This is a stub.
	Wez 2013/07/09 17:34:47 No need for this comment, nor the one below. No need for this comment, nor the one below.
	16 }

	17

	18 bool AudioPlayerImpl::ResetAudioPlayer(

	19 AudioPacket::SamplingRate sampling_rate) {

	20 LOG(WARNING) << "AudioPlayerImpl::ResetAudioPlayer(...) [unimplemented]";
	Wez 2013/07/09 17:34:47 nit: As above. nit: As above.
	21 return false; // TODO(solb) This is a stub.

	22 }

	23

	24 } // namespace remoting

OLD	NEW