Source/core/html/track/LoadableTextTrack.cpp - Issue 18856005: Fix HTMLMediaElement so that it doesn't add cues for disabled text tracks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/LoadableTextTrack.cpp

Issue 18856005: Fix HTMLMediaElement so that it doesn't add cues for disabled text tracks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/LoadableTextTrack.cpp

diff --git a/Source/core/html/track/LoadableTextTrack.cpp b/Source/core/html/track/LoadableTextTrack.cpp

index a856d17c83e5b3807132292d3c9c7d0eb9bd1ade..c279de6e107718ebba681f535af1dc6b6205c9b4 100644

--- a/Source/core/html/track/LoadableTextTrack.cpp

+++ b/Source/core/html/track/LoadableTextTrack.cpp

@@ -108,7 +108,7 @@ void LoadableTextTrack::newCuesAvailable(TextTrackLoader* loader)

m_cues->add(newCues[i]);

}

- if (client())

+ if (mode() != TextTrack::disabledKeyword() && client())

client()->textTrackAddCues(this, m_cues.get());

}

@@ -161,4 +161,3 @@ size_t LoadableTextTrack::trackElementIndex()

}

} // namespace WebCore