Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1885593002: Add dart_product GN build argument (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M runtime/BUILD.gn View 1 2 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 8 months ago (2016-04-12 15:34:43 UTC) #3
Ivan Posva
LGTM -Ivan https://codereview.chromium.org/1885593002/diff/20001/runtime/BUILD.gn File runtime/BUILD.gn (right): https://codereview.chromium.org/1885593002/diff/20001/runtime/BUILD.gn#newcode16 runtime/BUILD.gn:16: # shrink download size and decrease power ...
4 years, 8 months ago (2016-04-12 21:51:34 UTC) #4
Cutch
4 years, 8 months ago (2016-04-13 19:55:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
7e498d2ba5c8a1013f5f51d5c46ae2c8cc6750ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698