Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1885563002: GYP_DEFINES and DM flags for Vulkan bot (Closed)

Created:
4 years, 8 months ago by borenet2
Modified:
4 years, 8 months ago
Reviewers:
bsalomon, borenet, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Change to Debug mode #

Patch Set 3 : Remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -1 line) Patch
M tools/buildbot_spec.json View 1 1 chunk +352 lines, -0 lines 0 comments Download
M tools/buildbot_spec.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M tools/dm_flags.json View 1 1 chunk +285 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
borenet
4 years, 8 months ago (2016-04-12 13:23:33 UTC) #3
borenet
Changed to Debug mode.
4 years, 8 months ago (2016-04-12 13:44:47 UTC) #4
egdaniel
lgtm
4 years, 8 months ago (2016-04-12 13:52:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885563002/40001
4 years, 8 months ago (2016-04-12 14:59:50 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 15:14:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/71e185c060491c8b7b270a211590931715122786

Powered by Google App Engine
This is Rietveld 408576698