Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Issue 1885553002: Remove flag for HTMLMediaElement.srcObject. (Closed)

Created:
4 years, 8 months ago by Guido Urdaneta
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, haraken, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flag for HTMLMediaElement.srcObject. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Et8xbBUxrHs BUG=595326 Committed: https://crrev.com/ca76f3e67afd38eebe2b4cb975ce651b6780cefc Cr-Commit-Position: refs/heads/master@{#386759}

Patch Set 1 #

Patch Set 2 : fix statble webexposed test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/srcobject/HTMLMediaElementSrcObject.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Guido Urdaneta
Hi, PTAL
4 years, 8 months ago (2016-04-12 13:21:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885553002/1
4 years, 8 months ago (2016-04-12 14:18:12 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-12 15:40:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/210973)
4 years, 8 months ago (2016-04-12 15:52:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885553002/20001
4 years, 8 months ago (2016-04-12 17:47:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 19:31:08 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 19:32:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca76f3e67afd38eebe2b4cb975ce651b6780cefc
Cr-Commit-Position: refs/heads/master@{#386759}

Powered by Google App Engine
This is Rietveld 408576698