Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 188553002: Revert 255192 "Move TranslateManager unit tests out of the brows..." (Closed)

Created:
6 years, 9 months ago by oshima
Modified:
6 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 255192 "Move TranslateManager unit tests out of the brows..." > Move TranslateManager unit tests out of the browser_tests target. > > These are unit tests so they should be in the unit_tests target. A > TODO says this did not work before, but they appear to pass as unit > tests now, so this is just a code move. > > R=sky > BUG=270918 > > Review URL: https://codereview.chromium.org/186063007 TBR=danakj@chromium.org Test is failing on Linux memory bot. If this is passing on main waterfall, it may be due to sharding and this test may have some global state that previous test didn't cleanup TranslateManagerRenderViewHostTest.FetchLanguagesFromTranslateServer: Xlib: extension "RANDR" missing on display ":9". ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure Value of: fetcher != NULL Actual: false Expected: true ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure Value of: fetcher != NULL Actual: false Expected: true ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:662: Failure Value of: current_supported_languages.size() Actual: 54 Expected: server_languages.size() - 1 Which is: 7 ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00> ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure Value of: is_alpha Actual: true Expected: TranslateDownloadManager::IsAlphaLanguage(lang) Which is: false ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00> ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00> ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00> ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00> ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure Value of: is_alpha Actual: true Expected: TranslateDownloadManager::IsAlphaLanguage(lang) Which is: false ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1570 lines, -1576 lines) Patch
M trunk/src/chrome/browser/translate/translate_manager_browsertest.cc View 3 chunks +1570 lines, -6 lines 0 comments Download
D trunk/src/chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 1 chunk +0 lines, -1568 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
6 years, 9 months ago (2014-03-06 11:15:05 UTC) #1
oshima
6 years, 9 months ago (2014-03-06 11:15:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255312 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698