Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: tests/compiler/dart2js/analyze_test_test.dart

Issue 1885523002: Add summary to analyze_* tests. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/analyze_helper.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/analyze_test_test.dart
diff --git a/tests/compiler/dart2js/analyze_test_test.dart b/tests/compiler/dart2js/analyze_test_test.dart
index 4a2321b904695f6dfaff2c5edcc306869860447a..adc3ec793238e8964c09da1ae206d51415ff8cb8 100644
--- a/tests/compiler/dart2js/analyze_test_test.dart
+++ b/tests/compiler/dart2js/analyze_test_test.dart
@@ -57,8 +57,8 @@ const List<MessageKind> MESSAGE_SKIP_LIST = const <MessageKind>[
];
main(List<String> arguments) {
- List<String> options = <String>[];
- if (arguments.contains('-v') || arguments.contains(Flags.verbose)) {
+ List<String> options = <String>[]..addAll(arguments);
eernst 2016/04/12 12:10:47 On line 66 it looks like some elements in `argumen
Johnni Winther 2016/04/12 12:38:36 Done.
+ if (arguments.contains(Flags.verbose)) {
eernst 2016/04/12 12:10:47 I assume the intention is to disable the '-v' form
Johnni Winther 2016/04/12 12:38:36 Dooh. Removed the wrong subexpression....
options.add(Flags.verbose);
eernst 2016/04/12 12:10:47 If `arguments.contains(Flags.verbose)`, wouldn't `
Johnni Winther 2016/04/12 12:38:36 Dooh ... continued.
}
List<Uri> uriList = <Uri>[];
« no previous file with comments | « tests/compiler/dart2js/analyze_helper.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698