Add summary to analyze_* tests.

Add summary to analyze_* tests.

R=eernst@google.com

Committed: https://github.com/dart-lang/sdk/commit/b8c9bc3d425e0b64029f6269a049931b10dd8e70

[Johnni Winther, 2016-04-12 11:33:16]

johnniwinther@google.com changed reviewers:
+ eernst@google.com

[eernst, 2016-04-12 12:10:47]

I'd need a few comments on the treatment of `options`. Coming around IRL.

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:60: List<String> options =
<String>[]..addAll(arguments);
On line 66 it looks like some elements in `arguments` are not expected to be
options (they won't start with '-'). So why should all arguments be added to
options here? Are the non-option elements added to `options` but henceforth
ignored?

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:61: if
(arguments.contains(Flags.verbose)) {
I assume the intention is to disable the '-v' form, or is there a step where
'-v' is detected and replaced/supplemented by '--verbose'?

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:62: options.add(Flags.verbose);
If `arguments.contains(Flags.verbose)`, wouldn't `addAll(arguments)` already
have added `Flags.verbose` to `options`?

[Johnni Winther, 2016-04-12 12:38:36]

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:60: List<String> options =
<String>[]..addAll(arguments);
On 2016/04/12 12:10:47, eernst wrote:
> On line 66 it looks like some elements in `arguments` are not expected to be
> options (they won't start with '-'). So why should all arguments be added to
> options here? Are the non-option elements added to `options` but henceforth
> ignored?

Done.

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:61: if
(arguments.contains(Flags.verbose)) {
On 2016/04/12 12:10:47, eernst wrote:
> I assume the intention is to disable the '-v' form, or is there a step where
> '-v' is detected and replaced/supplemented by '--verbose'?

Dooh. Removed the wrong subexpression....

https://codereview.chromium.org/1885523002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:62: options.add(Flags.verbose);
On 2016/04/12 12:10:47, eernst wrote:
> If `arguments.contains(Flags.verbose)`, wouldn't `addAll(arguments)` already
> have added `Flags.verbose` to `options`?

Dooh ... continued.

[eernst, 2016-04-12 12:39:34]

LGTM

[Johnni Winther, 2016-04-12 13:02:59]

Description was changed from

==========
Add summary to analyze_* tests.
==========

to

==========
Add summary to analyze_* tests.

R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b8c9bc3d425e0b64029f6269a049931b10dd8e70
==========

[Johnni Winther, 2016-04-12 13:03:01]

Committed patchset #2 (id:20001) manually as
b8c9bc3d425e0b64029f6269a049931b10dd8e70 (presubmit successful).