Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1885513004: Introduce fragmentainerGroupCapacity(). (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce fragmentainerGroupCapacity(). During layout, the flow thread portion of the currently last fragmentainer group is unknown. So instead of calling logicalBottomInFlowThread() or logicalHeightInFlowThread(), we multiply the column height with the used value of column-count. Seems a bit cleaner to wrap this multiplication inside a method. Committed: https://crrev.com/e3b3a633c5faab29a591d4d34c9a725d6336e8bd Cr-Commit-Position: refs/heads/master@{#386817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
Please suggest a better name if you have one. :) I've been wanting to do ...
4 years, 8 months ago (2016-04-12 19:47:44 UTC) #2
leviw_travelin_and_unemployed
lgtm Naming is hard. I'm happy with this one as is.
4 years, 8 months ago (2016-04-12 20:07:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885513004/1
4 years, 8 months ago (2016-04-12 20:07:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 21:54:45 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 21:56:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b3a633c5faab29a591d4d34c9a725d6336e8bd
Cr-Commit-Position: refs/heads/master@{#386817}

Powered by Google App Engine
This is Rietveld 408576698