Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1885513003: GN: Use std::unique_ptr for owning pointers in Scope::NamedScopeMap. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use std::unique_ptr for owning pointers in Scope::NamedScopeMap. BUG=602726 Committed: https://crrev.com/ac5bf2c0d550e62f6cc58862990e7c4a1017cdf7 Cr-Commit-Position: refs/heads/master@{#388002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M tools/gn/scope.h View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/gn/scope.cc View 4 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885513003/1
4 years, 8 months ago (2016-04-18 18:11:43 UTC) #2
jbroman
4 years, 8 months ago (2016-04-18 19:09:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 19:12:12 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-18 19:47:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885513003/1
4 years, 8 months ago (2016-04-18 20:28:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:34:09 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:35:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac5bf2c0d550e62f6cc58862990e7c4a1017cdf7
Cr-Commit-Position: refs/heads/master@{#388002}

Powered by Google App Engine
This is Rietveld 408576698