Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1885503002: Revert of [Devil] Replace generated Devil config with jinja template. (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Devil] Replace generated Devil config with jinja template. (patchset #8 id:140001 of https://codereview.chromium.org/1812383003/ ) Reason for revert: I believe this change breaks content_browsertests on every Android tester in chromium.android. Examples: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/4031 https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/1457 https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester/builds/3759 Original issue's description: > [Devil] Replace generated Devil config with jinja template. > > This change will hopefully allow us to configure devil more based > on the build config. For example, it will let us use the same > android_sdk_tools to run tests that we use to build with. > > BUG= > > Committed: https://crrev.com/c2aa4243a9e00a2d0e254d9f6f73b41c00cb644d > Cr-Commit-Position: refs/heads/master@{#386461} TBR=droger@chromium.org,jbudorick@chromium.org,mikecase@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d408713145a9b75e155e1bf106105803ad40b1bd Cr-Commit-Position: refs/heads/master@{#386648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -243 lines) Patch
M build/android/BUILD.gn View 3 chunks +1 line, -20 lines 0 comments Download
M build/android/android.isolate View 1 chunk +1 line, -1 line 0 comments Download
D build/android/devil_chromium.jinja View 1 chunk +0 lines, -105 lines 0 comments Download
A build/android/devil_chromium.json View 1 chunk +69 lines, -0 lines 0 comments Download
M build/android/devil_chromium.py View 3 chunks +102 lines, -13 lines 0 comments Download
D build/android/gyp_devil_jinja_processor.py View 1 chunk +0 lines, -66 lines 0 comments Download
M build/android/setup.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
M build/android/test_runner.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/android/loading/gce/deploy.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Revert of [Devil] Replace generated Devil config with jinja template.
4 years, 8 months ago (2016-04-12 10:57:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885503002/1
4 years, 8 months ago (2016-04-12 10:57:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 10:58:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d408713145a9b75e155e1bf106105803ad40b1bd Cr-Commit-Position: refs/heads/master@{#386648}
4 years, 8 months ago (2016-04-12 11:00:27 UTC) #6
kjellander_chromium
4 years, 8 months ago (2016-04-12 12:17:43 UTC) #7
Message was sent while issue was closed.
On 2016/04/12 11:00:27, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d408713145a9b75e155e1bf106105803ad40b1bd
> Cr-Commit-Position: refs/heads/master@{#386648}

I can confirm that all the bots in
https://build.chromium.org/p/chromium.webrtc.fyi/waterfall are now green.
I filed https://bugs.chromium.org/p/chromium/issues/detail?id=602608 to ask why
these errors didn't show up in sheriff-o-matic.

Powered by Google App Engine
This is Rietveld 408576698