Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1885493002: [libfuzzer] Add custom max_len parameter for boringssl fuzzers. (Closed)

Created:
4 years, 8 months ago by mmoroz
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 Committed: https://crrev.com/146a2e8e36a2d1bd2bcd5999b14f4cd8ba80c499 Cr-Commit-Position: refs/heads/master@{#390340}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove depfile for dry run to test a possible fix. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M testing/libfuzzer/archive_corpus.py View 1 2 2 chunks +5 lines, -12 lines 0 comments Download
M testing/libfuzzer/fuzzer_test.gni View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 2 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 45 (20 generated)
mmoroz
4 years, 8 months ago (2016-04-12 10:49:14 UTC) #1
davidben
lgtm
4 years, 8 months ago (2016-04-12 14:57:16 UTC) #2
aizatsky
lgtm
4 years, 8 months ago (2016-04-12 17:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
4 years, 8 months ago (2016-04-13 08:23:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/158142)
4 years, 8 months ago (2016-04-13 08:55:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
4 years, 8 months ago (2016-04-13 10:00:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/158163)
4 years, 8 months ago (2016-04-13 10:21:04 UTC) #11
mmoroz
On 2016/04/13 10:21:04, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-13 10:44:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
4 years, 8 months ago (2016-04-14 09:38:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/158840)
4 years, 8 months ago (2016-04-14 10:11:33 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
4 years, 8 months ago (2016-04-14 22:22:51 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/159269)
4 years, 8 months ago (2016-04-14 22:42:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
4 years, 8 months ago (2016-04-15 10:21:42 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/159526)
4 years, 8 months ago (2016-04-15 11:02:02 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/20001
4 years, 8 months ago (2016-04-26 17:15:33 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/165066)
4 years, 8 months ago (2016-04-26 17:46:30 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/40001
4 years, 7 months ago (2016-04-27 11:30:42 UTC) #32
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 12:24:10 UTC) #34
mmoroz
On 2016/04/27 12:24:10, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-04-27 14:09:36 UTC) #35
aizatsky
On 2016/04/27 14:09:36, mmoroz wrote: > On 2016/04/27 12:24:10, commit-bot: I haz the power wrote: ...
4 years, 7 months ago (2016-04-27 18:01:10 UTC) #36
davidben
lgtm https://codereview.chromium.org/1885493002/diff/40001/third_party/boringssl/BUILD.gn File third_party/boringssl/BUILD.gn (right): https://codereview.chromium.org/1885493002/diff/40001/third_party/boringssl/BUILD.gn#newcode189 third_party/boringssl/BUILD.gn:189: libfuzzer_options = [ "max_len=4096" ] Oof. Sorry, I ...
4 years, 7 months ago (2016-04-27 18:06:22 UTC) #37
mmoroz
Thanks! Let's proceed with this for now.
4 years, 7 months ago (2016-04-28 10:27:21 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/40001
4 years, 7 months ago (2016-04-28 10:27:44 UTC) #41
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 10:32:48 UTC) #43
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:20 UTC) #44
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/146a2e8e36a2d1bd2bcd5999b14f4cd8ba80c499
Cr-Commit-Position: refs/heads/master@{#390340}

Powered by Google App Engine
This is Rietveld 408576698