|
|
Description[libfuzzer] Add custom max_len parameter for boringssl fuzzers.
R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org
BUG=569578
Committed: https://crrev.com/146a2e8e36a2d1bd2bcd5999b14f4cd8ba80c499
Cr-Commit-Position: refs/heads/master@{#390340}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Remove depfile for dry run to test a possible fix. #
Total comments: 1
Messages
Total messages: 45 (20 generated)
lgtm
lgtm
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/04/13 10:21:04, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Looks like broken goma prevents us from building: Traceback (most recent call last): File "/b/build/scripts/slave/compile.py", line 1338, in <module> error: failed to start goma; fallback has been disabled sys.exit(real_main()) File "/b/build/scripts/slave/compile.py", line 1334, in real_main return main(options, args) File "/b/build/scripts/slave/compile.py", line 857, in main_ninja goma_ready = goma_setup(options, env) File "/b/build/scripts/slave/compile.py", line 213, in goma_setup raise Exception('failed to start goma') Exception: failed to start goma step returned non-zero exit code: 1
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pgervais@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 ========== to ========== [libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 ==========
pgervais@chromium.org changed reviewers: - pgervais@chromium.org
The CQ bit was checked by mmoroz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmoroz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/04/27 12:24:10, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Not bad :) Mike, are you sure that we need that depfile? If yes, which another workaround may we use?
On 2016/04/27 14:09:36, mmoroz wrote: > On 2016/04/27 12:24:10, commit-bot: I haz the power wrote: > > Dry run: This issue passed the CQ dry run. > > Not bad :) > Mike, are you sure that we need that depfile? > > If yes, which another workaround may we use? let's live without it.
lgtm https://codereview.chromium.org/1885493002/diff/40001/third_party/boringssl/B... File third_party/boringssl/BUILD.gn (right): https://codereview.chromium.org/1885493002/diff/40001/third_party/boringssl/B... third_party/boringssl/BUILD.gn:189: libfuzzer_options = [ "max_len=4096" ] Oof. Sorry, I completely forgot this was in the pipeline when I made this a foreach. In a follow-up, I'll see about making these definitions live in the BoringSSL repository somewhere.
Thanks! Let's proceed with this for now.
The CQ bit was checked by mmoroz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from aizatsky@chromium.org Link to the patchset: https://codereview.chromium.org/1885493002/#ps40001 (title: "Remove depfile for dry run to test a possible fix.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885493002/40001
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 ========== to ========== [libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/146a2e8e36a2d1bd2bcd5999b14f4cd8ba80c499 Cr-Commit-Position: refs/heads/master@{#390340}
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 ========== to ========== [libfuzzer] Add custom max_len parameter for boringssl fuzzers. R=aizatsky@chromium.org, davidben@chromium.org, ochang@chromium.org BUG=569578 Committed: https://crrev.com/146a2e8e36a2d1bd2bcd5999b14f4cd8ba80c499 Cr-Commit-Position: refs/heads/master@{#390340} ========== |