Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
Committed: https://crrev.com/b9e68d8e121d5d4c5b93777919c767aa13da7256
Cr-Commit-Position: refs/heads/master@{#387502}

[danakj, 2016-04-12 22:39:13]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 22:39:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/1

[danakj, 2016-04-12 22:40:14]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the command_buffer_ is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to its
|command_buffer_|. The CmdBufferHelper::IsContextLost() method does:
  context_lost_ = error::IsError(command_buffer()->GetLastError());

which is similar to the original code. The GetLastError() methed
is used instead of GetLastState().error. Fortunately that method is
implemented as:
  return last_state_.error;

R=piman@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method does:
  context_lost_ = error::IsError(command_buffer()->GetLastError());

which is similar to the original code. The GetLastError() methed
is used instead of GetLastState().error. Fortunately that method is
implemented as:
  return last_state_.error;

R=piman@chromium.org
BUG=584497
==========

[danakj, 2016-04-12 22:40:28]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method does:
  context_lost_ = error::IsError(command_buffer()->GetLastError());

which is similar to the original code. The GetLastError() methed
is used instead of GetLastState().error. Fortunately that method is
implemented as:
  return last_state_.error;

R=piman@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
does:
  context_lost_ = error::IsError(command_buffer()->GetLastError());

which is similar to the original code. The GetLastError() methed
is used instead of GetLastState().error. Fortunately that method is
implemented as:
  return last_state_.error;

R=piman@chromium.org
BUG=584497
==========

[danakj, 2016-04-12 22:41:15]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
does:
  context_lost_ = error::IsError(command_buffer()->GetLastError());

which is similar to the original code. The GetLastError() methed
is used instead of GetLastState().error. Fortunately that method is
implemented as:
  return last_state_.error;

R=piman@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
==========

[commit-bot: I haz the power, 2016-04-13 00:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:02:25]

Dry run: This issue passed the CQ dry run.

[piman, 2016-04-14 01:35:10]

lgtm++

[Ken Russell (switch to Gerrit), 2016-04-14 01:43:27]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-04-14 01:43:27]

Thanks for your continued cleanups in this area. LGTM

[danakj, 2016-04-14 20:22:13]

PTAL

I've moved the check for lost context to RendererBlinkPlatformImpl.

And I've moved the null gpu_channel_host checks to the callers that can have
null as well. Now CreateOffscreenContext() will never return null.

[danakj, 2016-04-14 20:22:21]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 20:22:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/20001

[commit-bot: I haz the power, 2016-04-14 20:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 20:32:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[danakj, 2016-04-14 20:34:31]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-14 20:34:36]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 20:35:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/40001

[danakj, 2016-04-14 20:35:49]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 20:36:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/60001

[commit-bot: I haz the power, 2016-04-14 20:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 20:40:00]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-04-14 20:50:53]

On 2016/04/14 20:22:13, danakj wrote:
> PTAL
> 
> I've moved the check for lost context to RendererBlinkPlatformImpl.
> 
> And I've moved the null gpu_channel_host checks to the callers that can have
> null as well. Now CreateOffscreenContext() will never return null.

I added error messages to the new early outs in RendererBlinkPlatformImpl too.

[piman, 2016-04-14 22:07:50]

lgtm

[danakj, 2016-04-14 22:48:20]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-14 22:48:21]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1885463003/#ps140001
(title: "sharelost: moreerror")

[commit-bot: I haz the power, 2016-04-14 22:48:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/140001

[danakj, 2016-04-14 22:48:31]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-14 22:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/140001

[commit-bot: I haz the power, 2016-04-15 00:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 00:50:18]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[danakj, 2016-04-15 00:54:14]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
==========

[danakj, 2016-04-15 00:54:19]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-15 00:54:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885463003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885463003/140001

[commit-bot: I haz the power, 2016-04-15 01:00:39]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
==========

[commit-bot: I haz the power, 2016-04-15 01:00:41]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-15 01:02:21]

Description was changed from

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3DCommandBufferImpl::IsCommandBufferContextLost

This methods does the same things as GetGraphicsResetStatusKHR() on
the GLES2Implementation.

The first thing it does is:
  if (host_.get() && host_->IsLost())
    return true;

Here the |host_| is a GpuChannelHost. GLES2Implementation will call
GpuControl::IsGpuChannelLost(), where the GpuControl is given to
GLES2Implementation from WebGraphicsContext3DCommandBufferImpl as
the command_buffer_, which is a CommandBufferProxyImpl. The
CommandBufferProxyImpl::IsGpuChannelLost() method calls IsLost()
on its |channel_| which is the same pointer as the |host_| above.

The second thing it does is:
  gpu::CommandBuffer::State state = command_buffer_->GetLastState();
  return gpu::error::IsError(state.error);

Here the |command_buffer_| is the CommandBufferProxyImpl.
GLES2Implementation will call CmdBufferHelper::IsContextLost(). The
CmdBufferHelper is a GLES2CmdHelper created by
WebGraphicsContext3DCommandBufferImpl that points to the
same |command_buffer_|. The CmdBufferHelper::IsContextLost() method
returns "error::IsError(command_buffer()->GetLastError())" which is
similar to the original code. The GetLastError() methed is used
instead of "GetLastState().error". Fortunately that method is
implemented as "return last_state_.error" making it the exact same.

R=piman@chromium.org
BUG=584497

Committed: https://crrev.com/b9e68d8e121d5d4c5b93777919c767aa13da7256
Cr-Commit-Position: refs/heads/master@{#387502}
==========

[commit-bot: I haz the power, 2016-04-15 01:02:22]

Patchset 8 (id:??) landed as
https://crrev.com/b9e68d8e121d5d4c5b93777919c767aa13da7256
Cr-Commit-Position: refs/heads/master@{#387502}