chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java - Issue 1885463002: Create a Promise class to simplify dealing with async results.

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

Issue 1885463002: Create a Promise class to simplify dealing with async results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/Promise.java ('K') | « base/android/junit/src/org/chromium/base/PromiseTest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/sync/SyncAccountSwitcher.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/sync/SyncAccountSwitcher.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

index a3b8e69dc6e3751b17f50c08bc5d3a3ec26668ab..82379d4668140b521ca50c0f28a40aa8f2c945f2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

@@ -22,6 +22,8 @@ import android.widget.Spinner;

import android.widget.TextView;

import org.chromium.base.ApiCompatibilityUtils;

+import org.chromium.base.Callback;

+import org.chromium.base.Promise;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.firstrun.FirstRunView;

@@ -551,16 +553,16 @@ public class AccountSigninView extends FirstRunView

new ConfirmImportSyncDataDialog.Listener() {

@Override

public void onConfirm(boolean wipeData) {

- if (wipeData) {

- SyncUserDataWiper.wipeSyncUserData(new Runnable(){

- @Override

- public void run() {

- showConfirmSigninPage();

- }

- });

- } else {

- showConfirmSigninPage();

- }

+ Promise<Void> promise = (wipeData

Bernhard Bauer 2016/04/13 16:24:21 I'm thinking that it would be nice to extract this

PEConn 2016/05/31 10:29:55 You mean extract this? Promise<Void> promise = (w

Bernhard Bauer 2016/05/31 14:26:27 Yup, exactly.

PEConn 2016/06/01 08:58:37 Done.

+ ? SyncUserDataWiper.wipeSyncUserData()

+ : Promise.fulfilled((Void) null));

+ promise.then(new Callback<Void>() {

+ @Override

+ public void onResult(Void v) {

+ showConfirmSigninPage();

+ }

+ });

}

@Override