Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 1885433002: - Streamline comparisons in symbol table. (Closed)

Created:
4 years, 8 months ago by Ivan Posva
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Streamline comparisons in symbol table. - Avoid String::Equals method which considers the canonical bit. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/80f0f13fcde08984dd859006214268a0760602a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M runtime/vm/symbols.cc View 6 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ivan Posva
4 years, 8 months ago (2016-04-12 16:27:18 UTC) #2
siva
lgtm
4 years, 8 months ago (2016-04-12 22:03:05 UTC) #4
Ivan Posva
4 years, 8 months ago (2016-04-12 22:03:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80f0f13fcde08984dd859006214268a0760602a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698