Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2392)

Unified Diff: dart/tools/testing/dart/browser_controller.dart

Issue 188543003: Allow empty messages coming from the iframe to the driving page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/browser_controller.dart
diff --git a/dart/tools/testing/dart/browser_controller.dart b/dart/tools/testing/dart/browser_controller.dart
index b9f23ef028258f3884ee9df9347ca016b9a663fb..8c66ac19856986be56023b8fc6a30e5121066070 100644
--- a/dart/tools/testing/dart/browser_controller.dart
+++ b/dart/tools/testing/dart/browser_controller.dart
@@ -1419,7 +1419,8 @@ class BrowserTestingServer {
var parsedData = parseResult(msg);
if (parsedData) {
- // Only if the JSON was valid, we'll post it back.
+ // Only if the JSON message contains all required parameters,
+ // will we handle it and post it back to the test controller.
if ('message' in parsedData &&
'is_first_message' in parsedData &&
'is_status_update' in parsedData &&
@@ -1434,9 +1435,7 @@ class BrowserTestingServer {
"isFirstMessage/isStatusUpdate/isDone were all false");
}
}
- if (message) {
- reportMessage(message, isFirstMessage, isStatusUpdate);
- }
+ reportMessage(message, isFirstMessage, isStatusUpdate);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698