Avoid reattachWhitespaceSiblings when renderer does not change.

Source/core/dom/Element.cpp

Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 9f85ee93bf3a2dc8e26e5ad49a0538bbbf05acbe..18be6c30110c7a777ea712efe9b4d62eac27b626 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -1596,8 +1596,11 @@ StyleRecalcChange Element::recalcOwnStyle(StyleRecalcChange change)
     if (localChange == Reattach) {
         AttachContext reattachContext;
         reattachContext.resolvedStyle = newStyle.get();
+        bool rendererWillChange = needsAttach() || renderer();
         reattach(reattachContext);
-        return Reattach;
+        if (rendererWillChange || renderer())

[esprehn, 2014/03/06 19:40:24]

You're going to reattach on the initial attach of an element which is display:
none too which isn't right.

if !renderer() && needsAttach() before and then !renderer() after as well we
don't need need to reattach whitespace.

[rune, 2014/03/06 20:56:33]

The problem is that !renderer() && needsAttach() also happens when
lazyReattachIfAttached() has been called. For that case, there are possibly
whitespace renderer garbage lying around after detach() has been called from
lazyReattachIfAttached(). At this point, I don't know if that's the case or not.
This case is hit in two of the layout tests.

+            return Reattach;
+        return ReattachNoRenderer;
     }
 
     ASSERT(oldStyle);