Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1885413002: roll_webrtc.py: Fix syntax error for extra trybots line. (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll_webrtc.py: Fix syntax error for extra trybots line. In https://codereview.chromium.org/1877203008 an entry with CQ_EXTRA_TRYBOTS was added. It contained a syntax error that is now fixed. BUG=603239 NOTRY=True Committed: https://crrev.com/10907ea488ae542ffc52721c7ae029aebb405b43 Cr-Commit-Position: refs/heads/master@{#387903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/roll_webrtc.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_chromium
4 years, 8 months ago (2016-04-14 12:56:24 UTC) #2
Guido Urdaneta
On 2016/04/14 12:56:24, kjellander (chromium) wrote: lgtm
4 years, 8 months ago (2016-04-14 12:56:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885413002/1
4 years, 8 months ago (2016-04-14 13:16:56 UTC) #5
commit-bot: I haz the power
Transient error: Invalid delimiter in " was added. It contained a syntax error": Correct syntax ...
4 years, 8 months ago (2016-04-14 13:16:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885413002/1
4 years, 8 months ago (2016-04-18 14:29:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 14:36:55 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 14:37:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10907ea488ae542ffc52721c7ae029aebb405b43
Cr-Commit-Position: refs/heads/master@{#387903}

Powered by Google App Engine
This is Rietveld 408576698