Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

chrome/common/extensions/permissions/permission_message.h

Index: chrome/common/extensions/permissions/permission_message.h
diff --git a/chrome/common/extensions/permissions/permission_message.h b/chrome/common/extensions/permissions/permission_message.h
index ad814ae6f53fda137844d85aed63f2f5fc8ed793..4e86c84694557f8dcb37adcd553fc2bcd851050d 100644
--- a/chrome/common/extensions/permissions/permission_message.h
+++ b/chrome/common/extensions/permissions/permission_message.h
@@ -75,7 +75,7 @@ class PermissionMessage {
       const std::set<std::string>& hosts);
 
   // Creates the corresponding permission message.
-  PermissionMessage(ID id, const string16& message);
+  PermissionMessage(ID id, const string16& message, const string16& details);

[Yoyo Zhou, 2013/07/11 17:39:48]

nit: you could add a form of the constructor with no details argument.

   ~PermissionMessage();
 
   // Gets the id of the permission message, which can be used in UMA
@@ -86,6 +86,11 @@ class PermissionMessage {
   // the message will be empty for message types TYPE_NONE and TYPE_UNKNOWN.
   const string16& message() const { return message_; }
 
+  // Gets a localized message describing the details for this permission. Please
+  // note that the message will be empty for message types TYPE_NONE and
+  // TYPE_UNKNOWN.
+  const string16& details() const { return details_; }
+
   // Comparator to work with std::set.
   bool operator<(const PermissionMessage& that) const {
     return id_ < that.id_;
@@ -94,6 +99,7 @@ class PermissionMessage {
  private:
   ID id_;
   string16 message_;
+  string16 details_;
 };
 
 typedef std::vector<PermissionMessage> PermissionMessages;