Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4047)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Even more param reductions Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 1b6ddbc2938145ad952e3d7e092606b571220555..4a993e32247b5fd8291171056cc7d1d19b7ead45 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -70,7 +70,10 @@ class ExtensionInstallPrompt
explicit Prompt(PromptType type);
~Prompt();
+ // Sets the permission list for this prompt.
void SetPermissions(const std::vector<string16>& permissions);
+ // Sets the permission list details for this prompt.
+ void SetPermissionsDetails(const std::vector<string16>& details);
void SetInlineInstallWebstoreData(const std::string& localized_user_count,
double average_rating,
int rating_count);
@@ -91,6 +94,8 @@ class ExtensionInstallPrompt
string16 GetPermissionsHeading() const;
string16 GetOAuthHeading() const;
string16 GetRetainedFilesHeading() const;
+ string16 GetRetainedFilesHeadingWithCount() const;
+
bool ShouldShowPermissions() const;
// Getters for webstore metadata. Only populated when the type is
@@ -105,7 +110,9 @@ class ExtensionInstallPrompt
string16 GetRatingCount() const;
string16 GetUserCount() const;
size_t GetPermissionCount() const;
+ size_t GetPermissionsDetailsCount() const;
string16 GetPermission(size_t index) const;
+ string16 GetPermissionsDetails(size_t index) const;
size_t GetOAuthIssueCount() const;
const IssueAdviceInfoEntry& GetOAuthIssue(size_t index) const;
size_t GetRetainedFileCount() const;
@@ -139,6 +146,7 @@ class ExtensionInstallPrompt
// Permissions that are being requested (may not be all of an extension's
// permissions if only additional ones are being requested)
std::vector<string16> permissions_;
+ std::vector<string16> details_;
// Descriptions and details for OAuth2 permissions to display to the user.
// These correspond to permission scopes.

Powered by Google App Engine
This is Rietveld 408576698