Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4442)

Unified Diff: chrome/common/extensions/permissions/permissions_data.h

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polishing Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permissions_data.h
diff --git a/chrome/common/extensions/permissions/permissions_data.h b/chrome/common/extensions/permissions/permissions_data.h
index 0e6b647ace9ef14f57fa9d0c8dcbebe9283c1cb1..97cd69c04aab82506096002dbf3b9c216b966578 100644
--- a/chrome/common/extensions/permissions/permissions_data.h
+++ b/chrome/common/extensions/permissions/permissions_data.h
@@ -133,12 +133,17 @@ class PermissionsData {
// Returns the full list of permission messages that the given |extension|
// should display at install time.
- static PermissionMessages GetPermissionMessages(const Extension* extension);
+ // PermissionMessages come in two flavors, overview or detailed and the way to
+ // request one or the other is through the |details_only| parameter.
+ static PermissionMessages GetPermissionMessages(const Extension* extension,
+ bool details_only);
// Returns the full list of permission messages that the given |extension|
// should display at install time. The messages are returned as strings
// for convenience.
+ // PermissionMessages come in two flavors, overview or detailed and the way to
+ // request one or the other is through the |details_only| parameter.
static std::vector<string16> GetPermissionMessageStrings(
- const Extension* extension);
+ const Extension* extension, bool details_only);
// Returns true if the given |extension| can execute script on a page. If a
// UserScript object is passed, permission to run that specific script is

Powered by Google App Engine
This is Rietveld 408576698