Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polishing Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permissions_data.cc
diff --git a/chrome/common/extensions/permissions/permissions_data.cc b/chrome/common/extensions/permissions/permissions_data.cc
index 450c2ea5e4b1b2f0ab1d0326a3ae3bc0c8a57566..cec6d531e9db309fda523521a0edbcd8d0e9b5fc 100644
--- a/chrome/common/extensions/permissions/permissions_data.cc
+++ b/chrome/common/extensions/permissions/permissions_data.cc
@@ -421,25 +421,25 @@ bool PermissionsData::HasEffectiveAccessToAllHosts(const Extension* extension) {
// static
PermissionMessages PermissionsData::GetPermissionMessages(
- const Extension* extension) {
+ const Extension* extension, bool details_only) {
base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_);
if (ShouldSkipPermissionWarnings(extension)) {
return PermissionMessages();
} else {
return GetActivePermissions(extension)->GetPermissionMessages(
- extension->GetType());
+ extension->GetType(), details_only);
}
}
// static
std::vector<string16> PermissionsData::GetPermissionMessageStrings(
- const Extension* extension) {
+ const Extension* extension, bool details_only) {
base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_);
if (ShouldSkipPermissionWarnings(extension)) {
return std::vector<string16>();
} else {
return GetActivePermissions(extension)->GetWarningMessages(
- extension->GetType());
+ extension->GetType(), details_only);
}
}

Powered by Google App Engine
This is Rietveld 408576698