Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8132)

Unified Diff: chrome/common/extensions/permissions/permission_set.h

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polishing Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set.h
diff --git a/chrome/common/extensions/permissions/permission_set.h b/chrome/common/extensions/permissions/permission_set.h
index efecbf48df68bc75dcb09fdacfc625239482475f..7f1faf0dd96b3ad1e5c990909a67b7b6229d7448 100644
--- a/chrome/common/extensions/permissions/permission_set.h
+++ b/chrome/common/extensions/permissions/permission_set.h
@@ -78,13 +78,17 @@ class PermissionSet
// Gets the localized permission messages that represent this set.
// The set of permission messages shown varies by extension type.
- PermissionMessages GetPermissionMessages(Manifest::Type extension_type)
- const;
+ // PermissionMessages come in two flavors, overview or detailed and the way to
+ // request one or the other is through the |details_only| parameter.
+ PermissionMessages GetPermissionMessages(
+ Manifest::Type extension_type, bool details_only) const;
// Gets the localized permission messages that represent this set (represented
// as strings). The set of permission messages shown varies by extension type.
- std::vector<string16> GetWarningMessages(Manifest::Type extension_type)
- const;
+ // PermissionMessages come in two flavors, overview or detailed and the way to
+ // request one or the other is through the |details_only| parameter.
+ std::vector<string16> GetWarningMessages(
+ Manifest::Type extension_type, bool details_only) const;
// Returns true if this is an empty set (e.g., the default permission set).
bool IsEmpty() const;
@@ -171,8 +175,10 @@ class PermissionSet
std::set<PermissionMessage> GetAPIPermissionMessages() const;
// Gets the permission messages for the host permissions.
+ // PermissionMessages come in two flavors, overview or detailed and the way to
+ // request one or the other is through the |details_only| parameter.
std::set<PermissionMessage> GetHostPermissionMessages(
- Manifest::Type extension_type) const;
+ Manifest::Type extension_type, bool details_only) const;
// Returns true if |permissions| has an elevated API privilege level than
// this set.

Powered by Google App Engine
This is Rietveld 408576698