chrome/browser/extensions/extension_disabled_ui.cc - Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Polishing Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/extensions/api/permissions/permissions_api.cc ('k') | chrome/browser/extensions/extension_install_prompt.h » ('j') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc

index 6c887c154916eb7e53b28de30f34d979a38cec90..b927c299f9761d1604aba24b4fc63579613e2772 100644

--- a/chrome/browser/extensions/extension_disabled_ui.cc

+++ b/chrome/browser/extensions/extension_disabled_ui.cc

@@ -266,7 +266,7 @@ std::vector<string16> ExtensionDisabledGlobalError::GetBubbleViewMessages() {

IDS_EXTENSION_PROMPT_WILL_NOW_HAVE_ACCESS_TO));

std::vector<string16> permission_warnings =

extension_->GetActivePermissions()->GetWarningMessages(

- extension_->GetType());

+ extension_->GetType(), false);

for (size_t i = 0; i < permission_warnings.size(); ++i) {

messages.push_back(l10n_util::GetStringFUTF16(

IDS_EXTENSION_PERMISSION_LINE, permission_warnings[i]));