chrome/common/extensions/permissions/media_galleries_permission.cc - Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/permissions/media_galleries_permission.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Even more param reductions Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('K') | « chrome/common/extensions/permissions/chrome_scheme_hosts.cc ('k') | chrome/common/extensions/permissions/permission_message.h » ('j') | chrome/common/extensions/permissions/permission_message.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/permissions/media_galleries_permission.h"	5 #include "chrome/common/extensions/permissions/media_galleries_permission.h"

6	6

7 #include <set>	7 #include <set>

8 #include <string>	8 #include <string>

9	9

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 // If \|has_all_auto_detected\| is false, then Chrome will prompt the user at	71 // If \|has_all_auto_detected\| is false, then Chrome will prompt the user at

72 // runtime when the extension call the getMediaGalleries API.	72 // runtime when the extension call the getMediaGalleries API.

73 if (!has_all_auto_detected \|\| !has_read)	73 if (!has_all_auto_detected \|\| !has_read)

74 return result;	74 return result;

75	75

76 PermissionMessage::ID permission_id =	76 PermissionMessage::ID permission_id =

77 PermissionMessage::kMediaGalleriesAllGalleriesRead;	77 PermissionMessage::kMediaGalleriesAllGalleriesRead;

78 int message_id =	78 int message_id =

79 IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ_ALL_GALLERIES;	79 IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ_ALL_GALLERIES;

80 result.push_back(	80 result.push_back(

81 PermissionMessage(permission_id, l10n_util::GetStringUTF16(message_id)));	81 PermissionMessage(permission_id,

	82 l10n_util::GetStringUTF16(message_id),

	83 string16()));

82 return result;	84 return result;

83 }	85 }

84	86

85 } // namespace extensions	87 } // namespace extensions

OLD	NEW