Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

chrome/common/extensions/permissions/permission_message.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_MESSAGE_H_
 #define CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_MESSAGE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 52 matching lines @@
     kFavicon,
     kMusicManagerPrivate,
     kWebConnectable,
     kActivityLogPrivate,
     kBluetoothDevices,
     kEnumBoundary,
   };
 
   // Creates the corresponding permission message for a list of hosts. This is
   // simply a convenience method around the constructor, since the messages
-  // change depending on what hosts are present.
+  // change depending on what hosts are present. If |details_only| is true,
+  // the returned messages include full details of sites the extension
+  // requested access to, otherwise an overview/aggregate of the sites.
   static PermissionMessage CreateFromHostList(
-      const std::set<std::string>& hosts);
+      const std::set<std::string>& hosts, bool details_only);
 
   // Creates the corresponding permission message.
   PermissionMessage(ID id, const string16& message);
   ~PermissionMessage();
 
   // Gets the id of the permission message, which can be used in UMA
   // histograms.
   ID id() const { return id_; }
 
   // Gets a localized message describing this permission. Please note that
   // the message will be empty for message types TYPE_NONE and TYPE_UNKNOWN.
   const string16& message() const { return message_; }
 
   // Comparator to work with std::set.
   bool operator<(const PermissionMessage& that) const {
     return id_ < that.id_;
   }
 
  private:
   ID id_;
   string16 message_;

[Yoyo Zhou, 2013/07/10 23:18:58]

An alternative might be to have another string16 here for details. This would
help avoid having to pass the extra "is details" parameter everywhere.

 };
 
 typedef std::vector<PermissionMessage> PermissionMessages;
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_MESSAGE_H_