Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polishing Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/management/management_api.h" 5 #include "chrome/browser/extensions/api/management/management_api.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 DO_NOT_SKIP = 0, 72 DO_NOT_SKIP = 0,
73 PROCEED, 73 PROCEED,
74 ABORT 74 ABORT
75 }; 75 };
76 76
77 AutoConfirmForTest auto_confirm_for_test = DO_NOT_SKIP; 77 AutoConfirmForTest auto_confirm_for_test = DO_NOT_SKIP;
78 78
79 std::vector<std::string> CreateWarningsList(const Extension* extension) { 79 std::vector<std::string> CreateWarningsList(const Extension* extension) {
80 std::vector<std::string> warnings_list; 80 std::vector<std::string> warnings_list;
81 PermissionMessages warnings = 81 PermissionMessages warnings =
82 PermissionsData::GetPermissionMessages(extension); 82 PermissionsData::GetPermissionMessages(extension, false);
83 for (PermissionMessages::const_iterator iter = warnings.begin(); 83 for (PermissionMessages::const_iterator iter = warnings.begin();
84 iter != warnings.end(); ++iter) { 84 iter != warnings.end(); ++iter) {
85 warnings_list.push_back(UTF16ToUTF8(iter->message())); 85 warnings_list.push_back(UTF16ToUTF8(iter->message()));
86 } 86 }
87 87
88 return warnings_list; 88 return warnings_list;
89 } 89 }
90 90
91 scoped_ptr<management::ExtensionInfo> CreateExtensionInfo( 91 scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(
92 const Extension& extension, 92 const Extension& extension,
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 ProfileKeyedAPIFactory<ManagementAPI>* ManagementAPI::GetFactoryInstance() { 715 ProfileKeyedAPIFactory<ManagementAPI>* ManagementAPI::GetFactoryInstance() {
716 return &g_factory.Get(); 716 return &g_factory.Get();
717 } 717 }
718 718
719 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) { 719 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
720 management_event_router_.reset(new ManagementEventRouter(profile_)); 720 management_event_router_.reset(new ManagementEventRouter(profile_));
721 ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this); 721 ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
722 } 722 }
723 723
724 } // namespace extensions 724 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698