Issue 18854017: StyleSheet.ownerNode should be null when it gets orphaned.

Issue 18854017: StyleSheet.ownerNode should be null when it gets orphaned. (Closed)

Created:
7 years, 5 months ago by Hajime Morrita

Modified:
7 years, 5 months ago

Reviewers:
haraken

CC:
blink-reviews, gavinp+prerender_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

StyleSheet.ownerNode should be null when it gets orphaned. Orphan StyleSheet objects shouldn't pointe their ex-ownerNode. This change clears it when the owner detach such sheet objects. TEST=discarded-sheet-owner-null.html BUG=246203 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153764

Patch Set 1 #

Total comments: 2

Patch Set 2 : For landing #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -1 line)			Patch
A	LayoutTests/fast/dom/StyleSheet/discarded-sheet-owner-null.html	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/StyleSheet/discarded-sheet-owner-null-expected.txt	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLLinkElement.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM. Thanks for fixing this! https://codereview.chromium.org/18854017/diff/1/LayoutTests/fast/dom/StyleSheet/discarded-sheet-owner-null.html File LayoutTests/fast/dom/StyleSheet/discarded-sheet-owner-null.html (right): https://codereview.chromium.org/18854017/diff/1/LayoutTests/fast/dom/StyleSheet/discarded-sheet-owner-null.html#newcode5 LayoutTests/fast/dom/StyleSheet/discarded-sheet-owner-null.html:5: <link id="target", rel="stylesheet" href="old.css"> ...

7 years, 5 months ago (2013-07-09 05:44:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/18854017/5

7 years, 5 months ago (2013-07-09 05:59:10 UTC) #3

Message was sent while issue was closed.

Change committed as 153764

Expand Messages | Collapse Messages