Issue 18854016: Add runtime flags for Web Animations CSS and SVG implementations

Issue 18854016: Add runtime flags for Web Animations CSS and SVG implementations (Closed)

Created:
7 years, 5 months ago by dstockwell

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium, Timothy Loh, alancutter (OOO until 2018), shans, Steve Block, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add runtime flags for Web Animations CSS and SVG implementations. Expose in the public API so that they may be toggled on in virtual test suites. BUG=232278 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153808

Patch Set 1 #

Patch Set 2 : Turn on WebAnimations when WebAnimationsCSS/SVG is specified. Fix copy pasta. #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
M	Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.in	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	public/web/WebRuntimeFeatures.h	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18854016/1

7 years, 5 months ago (2013-07-09 05:31:41 UTC) #3

abarth-chromium

lgtm https://codereview.chromium.org/18854016/diff/13001/public/web/WebRuntimeFeatures.h File public/web/WebRuntimeFeatures.h (right): https://codereview.chromium.org/18854016/diff/13001/public/web/WebRuntimeFeatures.h#newcode127 public/web/WebRuntimeFeatures.h:127: WEBKIT_EXPORT static void enableWebAnimationsSVG(); Normally we pass a ...

7 years, 5 months ago (2013-07-09 17:51:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18854016/13001

7 years, 5 months ago (2013-07-09 17:51:48 UTC) #5

Message was sent while issue was closed.

Change committed as 153808

Expand Messages | Collapse Messages