Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 18854002: Fix an implicit cast from int64 to double in the i18n extension (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix an implicit cast from int64 to double in the i18n extension On MSVS, this throws an error BUG=v8:2745 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/extensions/i18n/number-format.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-08 15:10:10 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-08 15:20:57 UTC) #2
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-08 15:22:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15557 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698