Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1885373005: [Layout API] Convert (most of) FrameSelection to use Document::layoutViewItem() (Closed)

Created:
4 years, 8 months ago by pilgrim_google
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, dgrogan, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Convert (most of) FrameSelection to use Document::layoutViewItem() There are several references to Document::layoutView(), which is deprecated by the new layout API. I converted them to use layoutViewItem() instead. I added LayoutViewItem::invalidatePaintForSelection() to the API. There are no functional changes. BUG=499321 Committed: https://crrev.com/89a4287c0abb8a7816c079de9435b8ff22b133fa Cr-Commit-Position: refs/heads/master@{#388593}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutViewItem.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pilgrim_google
4 years, 8 months ago (2016-04-15 16:31:11 UTC) #2
eae
https://codereview.chromium.org/1885373005/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/1885373005/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp#newcode936 third_party/WebKit/Source/core/editing/FrameSelection.cpp:936: if (LayoutViewItem view = document->layoutViewItem()) Can this still be ...
4 years, 8 months ago (2016-04-17 18:17:50 UTC) #3
pilgrim_google
On 2016/04/17 at 18:17:50, eae wrote: > https://codereview.chromium.org/1885373005/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp > File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): > > https://codereview.chromium.org/1885373005/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp#newcode936 ...
4 years, 8 months ago (2016-04-20 21:35:47 UTC) #4
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-20 21:53:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885373005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885373005/20001
4 years, 8 months ago (2016-04-20 21:54:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 23:27:08 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:27:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89a4287c0abb8a7816c079de9435b8ff22b133fa
Cr-Commit-Position: refs/heads/master@{#388593}

Powered by Google App Engine
This is Rietveld 408576698