Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1885303002: Verify that a WebGLFramebuffer is bound to its context only. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify that a WebGLFramebuffer is bound to its context only. R= BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : use a release assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885303002/1
4 years, 8 months ago (2016-04-14 07:50:35 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 09:50:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885303002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885303002/2
4 years, 8 months ago (2016-04-14 16:05:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 18:20:02 UTC) #9
haraken
Worth landing this assert?
4 years, 8 months ago (2016-04-15 00:23:30 UTC) #10
sof
4 years, 8 months ago (2016-04-25 06:47:52 UTC) #11 
On 2016/04/15 00:23:30, haraken wrote:
> Worth landing this assert?

Things would break shortly hereafter if it didn't hold, so I'll trust the webgl
folks & not add this one.

Powered by Google App Engine
This is Rietveld 408576698