Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1885273004: Observatory: Tweak disassembly comments (Closed)

Created:
4 years, 8 months ago by sra1
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M runtime/observatory/lib/src/elements/code_view.dart View 1 2 chunks +16 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
LGTM after removing the 'minify: false' https://codereview.chromium.org/1885273004/diff/1/runtime/observatory/pubspec.yaml File runtime/observatory/pubspec.yaml (right): https://codereview.chromium.org/1885273004/diff/1/runtime/observatory/pubspec.yaml#newcode16 runtime/observatory/pubspec.yaml:16: minify: false not ...
4 years, 8 months ago (2016-04-15 14:01:09 UTC) #2
sra1
https://codereview.chromium.org/1885273004/diff/1/runtime/observatory/pubspec.yaml File runtime/observatory/pubspec.yaml (right): https://codereview.chromium.org/1885273004/diff/1/runtime/observatory/pubspec.yaml#newcode16 runtime/observatory/pubspec.yaml:16: minify: false On 2016/04/15 14:01:09, Cutch wrote: > not ...
4 years, 8 months ago (2016-04-15 16:48:37 UTC) #3
sra1
4 years, 8 months ago (2016-04-15 16:56:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fcf5278b6c0105d391e243d68ec69e504a9834d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698