Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 1885163002: Revert of Reland Switch Android gtests to use generated wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import contextlib 5 import contextlib
6 import datetime 6 import datetime
7 import json 7 import json
8 import os 8 import os
9 import re 9 import re
10 import urllib 10 import urllib
(...skipping 895 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 '-w', self.m.path['slave_build']] + args, **kwargs) 906 '-w', self.m.path['slave_build']] + args, **kwargs)
907 907
908 def run_test_suite(self, suite, verbose=True, isolate_file_path=None, 908 def run_test_suite(self, suite, verbose=True, isolate_file_path=None,
909 gtest_filter=None, tool=None, flakiness_dashboard=None, 909 gtest_filter=None, tool=None, flakiness_dashboard=None,
910 name=None, json_results_file=None, shard_timeout=None, 910 name=None, json_results_file=None, shard_timeout=None,
911 args=None, **kwargs): 911 args=None, **kwargs):
912 args = args or [] 912 args = args or []
913 args.extend(['--blacklist-file', self.blacklist_file]) 913 args.extend(['--blacklist-file', self.blacklist_file])
914 if verbose: 914 if verbose:
915 args.append('--verbose') 915 args.append('--verbose')
916 # TODO(agrieve): Remove once no more tests pass isolate_file_path (contained 916 if self.c.BUILD_CONFIG == 'Release':
917 # in wrapper script). 917 args.append('--release')
918 if isolate_file_path: 918 if isolate_file_path:
919 args.append('--isolate_file_path=%s' % isolate_file_path) 919 args.append('--isolate_file_path=%s' % isolate_file_path)
920 if gtest_filter: 920 if gtest_filter:
921 args.append('--gtest_filter=%s' % gtest_filter) 921 args.append('--gtest_filter=%s' % gtest_filter)
922 if tool: 922 if tool:
923 args.append('--tool=%s' % tool) 923 args.append('--tool=%s' % tool)
924 if flakiness_dashboard: 924 if flakiness_dashboard:
925 args.append('--flakiness-dashboard-server=%s' % 925 args.append('--flakiness-dashboard-server=%s' %
926 flakiness_dashboard) 926 flakiness_dashboard)
927 if json_results_file: 927 if json_results_file:
928 args.extend(['--json-results-file', json_results_file]) 928 args.extend(['--json-results-file', json_results_file])
929 # TODO(agrieve): Remove once no more tests pass shard_timeout (contained in
930 # wrapper script).
931 if shard_timeout: 929 if shard_timeout:
932 args.extend(['-t', str(shard_timeout)]) 930 args.extend(['-t', str(shard_timeout)])
933 self.test_runner( 931 self.test_runner(
934 name or str(suite), 932 name or str(suite),
935 args=args, 933 ['gtest', '-s', suite] + args,
936 wrapper_script_suite_name=suite,
937 env=self.m.chromium.get_env(), 934 env=self.m.chromium.get_env(),
938 **kwargs) 935 **kwargs)
939 936
940 def run_java_unit_test_suite(self, suite, verbose=True, 937 def run_java_unit_test_suite(self, suite, verbose=True,
941 json_results_file=None, suffix=None, **kwargs): 938 json_results_file=None, suffix=None, **kwargs):
942 args = [] 939 args = []
943 if verbose: 940 if verbose:
944 args.append('--verbose') 941 args.append('--verbose')
945 if self.c.BUILD_CONFIG == 'Release': 942 if self.c.BUILD_CONFIG == 'Release':
946 args.append('--release') 943 args.append('--release')
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
1260 script = self.c.test_runner 1257 script = self.c.test_runner
1261 if wrapper_script_suite_name: 1258 if wrapper_script_suite_name:
1262 script = self.m.chromium.output_dir.join('bin', 'run_%s' % 1259 script = self.m.chromium.output_dir.join('bin', 'run_%s' %
1263 wrapper_script_suite_name) 1260 wrapper_script_suite_name)
1264 else: 1261 else:
1265 env = kwargs.get('env', {}) 1262 env = kwargs.get('env', {})
1266 env['CHROMIUM_OUTPUT_DIR'] = env.get('CHROMIUM_OUTPUT_DIR', 1263 env['CHROMIUM_OUTPUT_DIR'] = env.get('CHROMIUM_OUTPUT_DIR',
1267 self.m.chromium.output_dir) 1264 self.m.chromium.output_dir)
1268 kwargs['env'] = env 1265 kwargs['env'] = env
1269 return self.m.python(step_name, script, args, **kwargs) 1266 return self.m.python(step_name, script, args, **kwargs)
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698