gyp-win-tool: Don't use shell=True on non-Windows hosts.

gyp-win-tool: Don't use shell=True on non-Windows hosts.

BUG=495204
R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/6ea68631cdabab9b7c5257657567a785a261692e

[Nico, 2016-04-13 18:38:16]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2016-04-13 18:38:16]

(i'm not sure why shell=True is needed on Windows, but it probably is needed for
something)

[Nico, 2016-04-13 18:38:59]

Oh, and with this applied, base links in component builds, so after that I don't
expect to touch this file for a while

[Nico, 2016-04-13 20:49:15]

Now probably even passes gyp's tests.

[scottmg, 2016-04-13 20:55:22]

I was going to say shell=False is fine on Windows too since it's just running
link.exe. But maybe there's some goma-prefix thing that needs it. (?) Not sure.

So this lgtm if you don't want to fiddle through that.

[Nico, 2016-04-13 20:58:46]

We don't link on goma. PS4 unconditionally makes it shell=False; if it breaks
something we'll know soon.

[Nico, 2016-04-13 20:59:05]

Description was changed from

==========
gyp-win-tool: Don't use shell=True on non-Windows hosts.

BUG=495204
==========

to

==========
gyp-win-tool: Don't use shell=True on non-Windows hosts.

Since it's probably not needed on Windows either, set shell=False
everywhere.

BUG=495204
==========

[Nico, 2016-04-13 21:24:16]

seems like it's needed on windows:
https://build.chromium.org/p/client.gyp/builders/win_try/builds/97

[Nico, 2016-04-13 21:24:49]

Description was changed from

==========
gyp-win-tool: Don't use shell=True on non-Windows hosts.

Since it's probably not needed on Windows either, set shell=False
everywhere.

BUG=495204
==========

to

==========
gyp-win-tool: Don't use shell=True on non-Windows hosts.

BUG=495204
==========

[Nico, 2016-04-13 21:25:32]

Description was changed from

==========
gyp-win-tool: Don't use shell=True on non-Windows hosts.

BUG=495204
==========

to

==========
gyp-win-tool: Don't use shell=True on non-Windows hosts.

BUG=495204
R=scottmg@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/6ea68631cdabab9b7c5257657567...
==========

[Nico, 2016-04-13 21:25:35]

Committed patchset #5 (id:80001) manually as
6ea68631cdabab9b7c5257657567a785a261692e (presubmit successful).

[scottmg, 2016-04-13 22:22:36]

On 2016/04/13 21:24:16, Nico wrote:
> seems like it's needed on windows:
> https://build.chromium.org/p/client.gyp/builders/win_try/builds/97

oh, right, i guess we just use "link.exe" not the full path. sorry for the
runaround.