Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 18851004: Moar doc (Closed)

Created:
7 years, 5 months ago by szager1
Modified:
6 years ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Document the use of GIT_ASKPASS and SSH_ASKPASS. BUG= R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211148

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M gclient_scm.py View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
szager1
7 years, 5 months ago (2013-07-10 00:44:54 UTC) #1
Dirk Pranke
lgtm, but make the CL subject / description actually say something useful before landing :). ...
7 years, 5 months ago (2013-07-10 00:54:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/18851004/1
7 years, 5 months ago (2013-07-10 01:01:36 UTC) #3
M-A Ruel
https://codereview.chromium.org/18851004/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/18851004/diff/1/gclient_scm.py#newcode1041 gclient_scm.py:1041: env = kwargs.get('env') or kwargs.setdefault('env', os.environ.copy()) In general I'd ...
7 years, 5 months ago (2013-07-10 01:02:50 UTC) #4
commit-bot: I haz the power
List of reviewers changed. maruel@chromium.org did a drive-by without LGTM'ing!
7 years, 5 months ago (2013-07-10 01:03:25 UTC) #5
szager1
7 years, 5 months ago (2013-07-11 17:39:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r211148.

Powered by Google App Engine
This is Rietveld 408576698