Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1885043010: Fix histogram names for document_write_page_load_metrics_observer (Closed)

Created:
4 years, 8 months ago by Charlie Harrison
Modified:
4 years, 8 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, jkarlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix histogram names for document_write_page_load_metrics_observer BUG=603926 Committed: https://crrev.com/f82333dc7fe6904d345fef725e967bae36daaaf8 Cr-Commit-Position: refs/heads/master@{#387653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Harrison
PTAL. This was a careless error I noticed as the metrics rolled into canary.
4 years, 8 months ago (2016-04-15 15:28:50 UTC) #2
Bryan McQuade
lgtm
4 years, 8 months ago (2016-04-15 18:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885043010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885043010/1
4 years, 8 months ago (2016-04-15 18:23:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 18:28:31 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 18:30:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f82333dc7fe6904d345fef725e967bae36daaaf8
Cr-Commit-Position: refs/heads/master@{#387653}

Powered by Google App Engine
This is Rietveld 408576698