Chromium Code Reviews
DescriptionReland of upload of "Flock master startup." (patchset #1 id:1 of https://codereview.chromium.org/1883193003/ )
Reason for revert:
dsansome missed https://chromiumcodereview.appspot.com/1884873010/ :(
Original issue's description:
> Revert of Reupload of "Flock master startup." (patchset #2 id:20001 of https://codereview.chromium.org/1892643002/ )
>
> Reason for revert:
> if [ -n $(ps -p$PID -o pid=) ]; then
>
> This doesn't work at all. Check the return code of ps or quote the string. http://o/293111
>
> Original issue's description:
> > Reupload of "Flock master startup."
> >
> > This was reverted because the path manipulation didn't work for internal masters. Original patchset here: https://chromiumcodereview.appspot.com/1883813003/.
> >
> > BUG=588118
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299942
>
> TBR=pgervais@chromium.org,dnj@chromium.org,stip@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=588118
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299948
TBR=pgervais@chromium.org,dnj@chromium.org,dsansome@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588118
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299949
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||