Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: src/log.cc

Issue 1885033005: Portable Linux perf map formatting. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mac OS X fix (cinttypes is in tr1 there). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index e77799802156726b0630ce26452afc8b47ff53a1..32f54b6979789a7b351fc58aa3cc8175461a9f2e 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -4,6 +4,7 @@
#include "src/log.h"
+#include <inttypes.h>
#include <cstdarg>
#include <sstream>
@@ -284,9 +285,9 @@ void PerfBasicLogger::LogRecordedBuffer(AbstractCode* code, SharedFunctionInfo*,
return;
}
- base::OS::FPrint(perf_output_handle_, "%p %x %.*s\n",
- code->instruction_start(), code->instruction_size(), length,
- name);
+ base::OS::FPrint(perf_output_handle_, "%" PRIxPTR " %x %.*s\n",
Jarin 2016/04/14 12:16:53 Couldn't you use V8PRIxPTR?
Stefano Sanfilippo 2016/04/14 12:31:54 Done.
+ reinterpret_cast<uintptr_t>(code->instruction_start()),
+ code->instruction_size(), length, name);
}
// Low-level logging support.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698