BuildBot: Add anchors for unbound aliases.

third_party/buildbot_8_4p1/buildbot/status/web/build.py

 # This file is part of Buildbot.  Buildbot is free software: you can
 # redistribute it and/or modify it under the terms of the GNU General Public
 # License as published by the Free Software Foundation, version 2.
 #
 # This program is distributed in the hope that it will be useful, but WITHOUT
 # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 # FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
 # details.
 #
 # You should have received a copy of the GNU General Public License along with
@@ skipping 103 matching lines @@
                 step['time_to_run'] = ""
 
             cxt['steps'].append(step)
 
             step['link'] = req.childLink("steps/%s" % urllib.quote(s.getName(),
                                                                    safe=''))
             step['text'] = " ".join(s.getText())
             step['urls'] = map(lambda x:dict(url=x[1],logname=x[0]), s.getURLs().items())
             step['nest_level'] = s.getNestLevel()
 
-            step['aliases'] = {}
-            for base, aliases in s.getAliases().iteritems():
-                step['aliases'][base] = [{
-                    'text': a[0],
-                    'url': a[1],
-                } for a in aliases]
-
             step['logs']= []
 
             for l in s.getLogs():
                 logname = l.getName()
                 step['logs'].append({ 'link': req.childLink("steps/%s/logs/%s" %
                                            (urllib.quote(s.getName(), safe=''),
                                             urllib.quote(logname, safe=''))),
                                       'name': logname })
 
+            step['aliases'] = {}
+            seen_aliases = set()
+            for base, aliases in s.getAliases().iteritems():
+                step['aliases'][base] = [{
+                    'text': a[0],
+                    'url': a[1],
+                } for a in aliases]
+                seen_aliases.add(base)
+
+            seen_aliases.difference_update(s['logname'] for s in step['urls'])
+            seen_aliases.difference_update(s['name'] for s in step['logs'])
+
+            # Append link-less log anchors for unbased aliases to attach to.
+            #
+            # We include an empty link so that custom templates that don't
+            # support aliases don't crash when trying to render these anchors.
+            # This will cause waterfalls that have alias data but haven't
+            # updated their templates to render them to show blank links. This
+            # is okay, since waterfalls that accept alias data should have
+            # their templates updated to render this data.
+            for base in sorted(seen_aliases):
+                step['logs'].append({'name': base, 'link': ''})
+

[dnj, 2016/04/13 15:39:59]

Note: because templates are immediately loaded post-sync, but this code won't be
loaded before restart, there are 4 scenarios here:

1) Waterfall has old (before-alias) template, so it doesn't know about alises.
In this case, it will render links.
1a) If there are aliases (e.g., it's running a recipe/Annotee that emits them),
this new code will cause empty links to be emitted.
1b) If there are no aliases, this code will not run and nothing will be
different. It will show "- no logs -" like normal.

2) Waterfall has new templates (sync), but hasn't been restarted. This will not
affect them, as they will not generate empty links, so the new template code
will not be hit.
3) Waterfall has new templates and has been restarted. This will cause them to
generate empty links, which will be rendered as link-less anchors.

It should be noted that (1b) is not something that should happen. This is
because any waterfall that runs code that generates aliases should have their
templates updated to render aliases. AFAIK only internal waterfalls have not had
these updates. If, however, aliases are generated, nothing bad will happen, as
per (1b).

         ps = cxt['properties'] = []
         for name, value, source in b.getProperties().asList():
             value = str(value)
             p = { 'name': name, 'value': value, 'source': source}
             if len(value) > 500:
                 p['short_value'] = value[:500]
 
             ps.append(p)
 
         
@@ skipping 112 matching lines @@
         try:
             num = int(path)
         except ValueError:
             num = None
         if num is not None:
             build_status = self.builder_status.getBuild(num)
             if build_status:
                 return StatusResourceBuild(build_status)
 
         return HtmlResource.getChild(self, path, req)