Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: Source/modules/filesystem/DirectoryReaderBase.h

Issue 188503002: Oilpan: add transition types to FileSystem APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Avoid DirectoryReaderBase virtuals Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/filesystem/DirectoryReaderBase.h
diff --git a/Source/modules/filesystem/DirectoryReaderBase.h b/Source/modules/filesystem/DirectoryReaderBase.h
index 5e1ac5e4fac23c728eb5f4479a36d73b52b49b05..2758ca5cd74eb387b231c245c7ccc6ceab8aec33 100644
--- a/Source/modules/filesystem/DirectoryReaderBase.h
+++ b/Source/modules/filesystem/DirectoryReaderBase.h
@@ -31,6 +31,7 @@
#ifndef DirectoryReaderBase_h
#define DirectoryReaderBase_h
+#include "heap/Handle.h"
#include "modules/filesystem/DOMFileSystemBase.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -38,20 +39,25 @@
namespace WebCore {
-class DirectoryReaderBase : public RefCounted<DirectoryReaderBase> {
+class DirectoryReaderBase : public RefCountedWillBeGarbageCollectedFinalized<DirectoryReaderBase> {
public:
DOMFileSystemBase* filesystem() const { return m_fileSystem.get(); }
void setHasMoreEntries(bool hasMoreEntries) { m_hasMoreEntries = hasMoreEntries; }
+ void trace(Visitor* visitor)
+ {
+ visitor->trace(m_fileSystem);
+ }
+
protected:
- DirectoryReaderBase(PassRefPtr<DOMFileSystemBase> fileSystem, const String& fullPath)
+ DirectoryReaderBase(PassRefPtrWillBeRawPtr<DOMFileSystemBase> fileSystem, const String& fullPath)
: m_fileSystem(fileSystem)
, m_fullPath(fullPath)
, m_hasMoreEntries(true)
{
}
- RefPtr<DOMFileSystemBase> m_fileSystem;
+ RefPtrWillBeMember<DOMFileSystemBase> m_fileSystem;
// This is a virtual path.
String m_fullPath;

Powered by Google App Engine
This is Rietveld 408576698