Oilpan: add transition types to FileSystem APIs.

Source/modules/filesystem/FileWriter.cpp

 /*
  * Copyright (C) 2010 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 #include "core/fileapi/Blob.h"
 #include "public/platform/WebFileWriter.h"
 #include "public/platform/WebURL.h"
 #include "wtf/CurrentTime.h"
 
 namespace WebCore {
 
 static const int kMaxRecursionDepth = 3;
 static const double progressNotificationIntervalMS = 50;
 
-PassRefPtr<FileWriter> FileWriter::create(ExecutionContext* context)
+PassRefPtrWillBeRawPtr<FileWriter> FileWriter::create(ExecutionContext* context)
 {
-    RefPtr<FileWriter> fileWriter(adoptRef(new FileWriter(context)));
+    RefPtrWillBeRawPtr<FileWriter> fileWriter(adoptRefWillBeRefCountedGarbageCollected(new FileWriter(context)));
     fileWriter->suspendIfNeeded();
     return fileWriter.release();
 }
 
 FileWriter::FileWriter(ExecutionContext* context)
     : ActiveDOMObject(context)
     , m_readyState(INIT)
     , m_operationInProgress(OperationNone)
     , m_queuedOperation(OperationNone)
     , m_bytesWritten(0)
     , m_bytesToWrite(0)
     , m_truncateLength(-1)
     , m_numAborts(0)
     , m_recursionDepth(0)
     , m_lastProgressNotificationTimeMS(0)
 {
     ScriptWrappable::init(this);
 }
 
 FileWriter::~FileWriter()

[haraken, 2014/03/10 01:55:26]

Just to confirm: Is this destructor safe? This destructor is doing a lot of
non-trivial things. As far as I see, this destructor looks safe since it won't
touch any on-heap objects that can be collected in the same GC cycle.

[sof, 2014/03/10 10:01:23]

Re-verified that it is safe as it currently is.

Not a future-proof property.. would it be worth adding a comment?

[haraken, 2014/03/10 10:19:35]

Won't be needed :) Once we have the ASAN build in the future, we will be
asserted if we touch on-heap objects inside destructors.

 {
     ASSERT(!m_recursionDepth);
     if (m_readyState == WRITING)
         stop();
 }
 
 const AtomicString& FileWriter::interfaceName() const
 {
     return EventTargetNames::FileWriter;
 }
@@ skipping 232 matching lines @@
     ASSERT(m_recursionDepth >= 0);
 }
 
 void FileWriter::setError(FileError::ErrorCode errorCode, ExceptionState& exceptionState)
 {
     ASSERT(errorCode);
     FileError::throwDOMException(exceptionState, errorCode);
     m_error = FileError::create(errorCode);
 }
 
+void FileWriter::trace(Visitor* visitor)
+{
+    visitor->trace(m_error);
+    visitor->trace(m_blobBeingWritten);
+    FileWriterBase::trace(visitor);
+}
+
 } // namespace WebCore