Oilpan: add transition types to FileSystem APIs.

Source/modules/filesystem/SyncCallbackHelper.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 17 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SyncCallbackHelper_h
 #define SyncCallbackHelper_h
 
 #include "bindings/v8/ExceptionState.h"
 #include "core/fileapi/FileError.h"
 #include "core/html/VoidCallback.h"
+#include "heap/Handle.h"
 #include "modules/filesystem/DirectoryEntry.h"
 #include "modules/filesystem/DirectoryReaderSync.h"
 #include "modules/filesystem/EntriesCallback.h"
 #include "modules/filesystem/EntryCallback.h"
 #include "modules/filesystem/EntrySync.h"
 #include "modules/filesystem/ErrorCallback.h"
 #include "modules/filesystem/FileEntry.h"
 #include "modules/filesystem/FileSystemCallback.h"
 #include "modules/filesystem/MetadataCallback.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
 template <typename ResultType, typename CallbackArg>
 struct HelperResultType {
-    typedef PassRefPtr<ResultType> ReturnType;
-    typedef RefPtr<ResultType> StorageType;
+    typedef PassRefPtrWillBeRawPtr<ResultType> ReturnType;

[haraken, 2014/03/07 08:24:35]

This is used by only one place. Shall we avoid using typedef?

[sof, 2014/03/07 09:37:36]

It is used later by derived classes to gain access storage & return types.

+    typedef RefPtrWillBeRawPtr<ResultType> StorageType;

[haraken, 2014/03/07 08:24:35]

This is unused. Shall we remove?

[sof, 2014/03/07 09:37:36]

Same, elsewhere used.

 
     static ReturnType createFromCallbackArg(CallbackArg argument)
     {
         return ResultType::create(argument);
     }
 };
 
 template <>
 struct HelperResultType<EntrySyncVector, const EntryVector&> {
     typedef EntrySyncVector ReturnType;
     typedef EntrySyncVector StorageType;

[haraken, 2014/03/07 08:24:35]

Looks like these two typedefs are unused. Shall we remove?

[sof, 2014/03/07 09:37:36]

Ditto, elsewhere used.

 
     static EntrySyncVector createFromCallbackArg(const EntryVector& entries)
     {
         EntrySyncVector result;
         size_t entryCount = entries.size();
         result.reserveInitialCapacity(entryCount);
         for (size_t i = 0; i < entryCount; ++i)
             result.uncheckedAppend(EntrySync::create(entries[i].get()));
         return result;
     }
 };
 
 // A helper template for FileSystemSync implementation.
 template <typename SuccessCallback, typename CallbackArg, typename ResultType>
 class SyncCallbackHelper {
     WTF_MAKE_NONCOPYABLE(SyncCallbackHelper);
+    STACK_ALLOCATED();
 public:
     typedef SyncCallbackHelper<SuccessCallback, CallbackArg, ResultType> HelperType;
     typedef HelperResultType<ResultType, CallbackArg> ResultTypeTrait;
     typedef typename ResultTypeTrait::StorageType ResultStorageType;
     typedef typename ResultTypeTrait::ReturnType ResultReturnType;
 
     SyncCallbackHelper()
         : m_errorCode(FileError::OK)
         , m_completed(false)
     {
@@ skipping 68 matching lines @@
         m_result = ResultTypeTrait::createFromCallbackArg(result);
         m_completed = true;
     }
 
     ResultStorageType m_result;
     FileError::ErrorCode m_errorCode;
     bool m_completed;
 };
 
 struct EmptyType : public RefCounted<EmptyType> {
-    static PassRefPtr<EmptyType> create(EmptyType*)
+    static PassRefPtrWillBeRawPtr<EmptyType> create(EmptyType*)
     {
         return nullptr;
     }
 };
 
 typedef SyncCallbackHelper<EntryCallback, Entry*, EntrySync> EntrySyncCallbackHelper;
 typedef SyncCallbackHelper<EntriesCallback, const EntryVector&, EntrySyncVector> EntriesSyncCallbackHelper;
 typedef SyncCallbackHelper<MetadataCallback, Metadata*, Metadata> MetadataSyncCallbackHelper;
 typedef SyncCallbackHelper<VoidCallback, EmptyType*, EmptyType> VoidSyncCallbackHelper;
 typedef SyncCallbackHelper<FileSystemCallback, DOMFileSystem*, DOMFileSystemSync> FileSystemSyncCallbackHelper;
 
 } // namespace WebCore
 
 #endif // SyncCallbackHelper_h