Oilpan: add transition types to FileSystem APIs.

Source/modules/filesystem/FileWriter.cpp

 /*
  * Copyright (C) 2010 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 #include "core/fileapi/Blob.h"
 #include "public/platform/WebFileWriter.h"
 #include "public/platform/WebURL.h"
 #include "wtf/CurrentTime.h"
 
 namespace WebCore {
 
 static const int kMaxRecursionDepth = 3;
 static const double progressNotificationIntervalMS = 50;
 
-PassRefPtr<FileWriter> FileWriter::create(ExecutionContext* context)
+PassRefPtrWillBeRawPtr<FileWriter> FileWriter::create(ExecutionContext* context)
 {
-    RefPtr<FileWriter> fileWriter(adoptRef(new FileWriter(context)));
+    RefPtrWillBeRawPtr<FileWriter> fileWriter(adoptRefWillBeRefCountedGarbageCollected(new FileWriter(context)));
     fileWriter->suspendIfNeeded();
     return fileWriter.release();
 }
 
 FileWriter::FileWriter(ExecutionContext* context)
     : ActiveDOMObject(context)
     , m_readyState(INIT)
     , m_operationInProgress(OperationNone)
     , m_queuedOperation(OperationNone)
     , m_bytesWritten(0)
@@ skipping 214 matching lines @@
         ASSERT(m_truncateLength == -1);
         ASSERT(!m_blobBeingWritten.get());
         ASSERT(m_readyState == DONE);
         break;
     case OperationAbort:
         if (m_operationInProgress == OperationWrite || m_operationInProgress == OperationTruncate)
             writer()->cancel();
         else if (m_operationInProgress != OperationAbort)
             operation = OperationNone;
         m_queuedOperation = OperationNone;
         m_blobBeingWritten.clear();

[haraken, 2014/03/07 08:24:35]

This looks dangerous.

FileWriter's destructor calls doOperation() and the doOperation() touches 
|m_blobBeingWritten|, which is on the heap.

[sof, 2014/03/07 09:37:36]

Very well spotted, but isn't this OK, really? i.e., it clears the Member & isn't
touching the object.

         m_truncateLength = -1;
         break;
     }
     ASSERT(m_queuedOperation == OperationNone);
     m_operationInProgress = operation;
 }
 
 void FileWriter::signalCompletion(FileError::ErrorCode code)
 {
     m_readyState = DONE;
@@ skipping 17 matching lines @@
     ASSERT(m_recursionDepth >= 0);
 }
 
 void FileWriter::setError(FileError::ErrorCode errorCode, ExceptionState& exceptionState)
 {
     ASSERT(errorCode);
     FileError::throwDOMException(exceptionState, errorCode);
     m_error = FileError::create(errorCode);
 }
 
+void FileWriter::trace(Visitor* visitor)
+{
+    visitor->trace(m_error);
+    visitor->trace(m_blobBeingWritten);
+    FileWriterBase::trace(visitor);
+}
+
 } // namespace WebCore