Oilpan: add transition types to FileSystem APIs.

Source/modules/filesystem/DirectoryEntrySync.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
 class DirectoryReaderSync;
 class ExceptionState;
 class FileEntrySync;
 
 class DirectoryEntrySync FINAL : public EntrySync {

[haraken, 2014/03/07 08:24:35]

Shall we add a trace() method to all GarbageCollected sub-classes? The same
comment for other places in this CL.

[sof, 2014/03/07 09:37:36]

I don't think it adds much value, given the class's only function --
FileEntrySync&DirectoryEntrySync are just here to get the kind/type of the
EntrySync right. Ditto for FileEntry and DirectoryEntry. That's why I didn't add
them.

[haraken, 2014/03/10 01:55:26]

I'd prefer to add (and in fact we have added) trace() methods to all
garbage-collected classes even if the classes don't have any members. This is
for programming consistency. Instead of making developers add trace() methods
every time they add new members, it would be simpler and less error-prone to add
trace() methods when we move the class hierarchy to the heap.

[sof, 2014/03/10 10:01:23]

ok, added the methods here & will follow that.

(It doesn't apply here, but if we can be judicious about adding "empty" trace()s
to classes having no other virtuals, I'd prefer that.)

 public:
-    static PassRefPtr<DirectoryEntrySync> create(PassRefPtr<DOMFileSystemBase> fileSystem, const String& fullPath)
+    static PassRefPtrWillBeRawPtr<DirectoryEntrySync> create(PassRefPtrWillBeRawPtr<DOMFileSystemBase> fileSystem, const String& fullPath)
     {
-        return adoptRef(new DirectoryEntrySync(fileSystem, fullPath));
+        return adoptRefWillBeNoop(new DirectoryEntrySync(fileSystem, fullPath));
     }
     virtual bool isDirectory() const OVERRIDE { return true; }
 
-    PassRefPtr<DirectoryReaderSync> createReader();
-    PassRefPtr<FileEntrySync> getFile(const String& path, const Dictionary&, ExceptionState&);
-    PassRefPtr<DirectoryEntrySync> getDirectory(const String& path, const Dictionary&, ExceptionState&);
+    PassRefPtrWillBeRawPtr<DirectoryReaderSync> createReader();
+    PassRefPtrWillBeRawPtr<FileEntrySync> getFile(const String& path, const Dictionary&, ExceptionState&);
+    PassRefPtrWillBeRawPtr<DirectoryEntrySync> getDirectory(const String& path, const Dictionary&, ExceptionState&);
     void removeRecursively(ExceptionState&);
 
 private:
-    DirectoryEntrySync(PassRefPtr<DOMFileSystemBase>, const String& fullPath);
+    DirectoryEntrySync(PassRefPtrWillBeRawPtr<DOMFileSystemBase>, const String& fullPath);
 };
 
 DEFINE_TYPE_CASTS(DirectoryEntrySync, EntrySync, entry, entry->isDirectory(), entry.isDirectory());
 
 }
 
 #endif // DirectoryEntrySync_h